Merge pull request #1333 from peverwhee/fix-memory-leak

cam6_4_100: Memory leak fixes

Author: peverwhee

.gitmodules

@@ -36,7 +36,7 @@
 [submodule "atmos_phys"]
 	path = src/atmos_phys
 	url = https://github.com/ESCOMP/atmospheric_physics
-        fxtag = atmos_phys0_14_000
+        fxtag = atmos_phys0_14_001
         fxrequired = AlwaysRequired
 	fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
 

doc/ChangeLog

@@ -1,5 +1,66 @@
 ===============================================================
 
+Tag name: cam6_4_100
+Originator(s): peverwhee, gdicker1
+Date: 26 June 2025
+One-line Summary: Memory leak fixes
+Github PR URL: https://github.com/ESCOMP/CAM/pull/1333
+
+Purpose of changes (include the issue number and title text for each relevant GitHub issue):
+
+- closes #1318 - NVHPC compilers have a memory leak due to valid code being treated as allocation on assign in coords_1d.F90
+  - brings in new atmospheric_physics tag to address the leak
+
+- fixes leak in RRTMGP and modifies interfaces
+
+Describe any changes made to build system: none
+
+Describe any changes made to the namelist: none
+
+List any changes to the defaults for the boundary datasets: none
+
+Describe any substantial timing or memory changes: none
+
+Code reviewed by: cacraig
+
+List all files eliminated: n/a
+
+List all files added and what they do: n/a
+
+List all existing files that have been modified, and describe the changes:
+
+.gitmodules
+- update to atmospheric_physics tag atmos_phys0_14_001
+
+src/atmos_phys
+- update submodule
+
+src/physics/rrtmgp/radiation.F90
+- modify calling list to rrtmgp_post to match new atmospheric_physics tag
+
+If there were any failures reported from running test_driver.sh on any test
+platform, and checkin with these failures has been OK'd by the gatekeeper,
+then copy the lines from the td.*.status files for the failed tests to the
+appropriate machine below.  All failed tests must be justified.
+
+derecho/intel/aux_cam:
+
+SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: FAIL)
+- pre-existing failure due to build-namelist error requiring CLM/CTSM external update
+
+derecho/nvhpc/aux_cam: All PASS
+
+izumi/nag/aux_cam: All PASS
+
+izumi/gnu/aux_cam: All PASS
+
+CAM tag used for the baseline comparison tests if different than previous
+tag:
+
+Summarize any changes to answers: BFB
+
+===============================================================
+
 Tag name: cam6_4_099
 Originator(s): eaton
 Date: 24 June 2025

src/atmos_phys

@@ -1463,8 +1463,9 @@ subroutine radiation_tend( &
    cam_out%netsw(:) = 0._r8
 
    ! Calculate radiative heating (Q*dp), set netsw flux, and do object cleanup
-   call rrtmgp_post_run(qrs_prime(:ncol,:), qrl_prime(:ncol,:), fsns(:ncol), state%pdel(:ncol,:), atm_optics_sw, cloud_sw, aer_sw, &
-                  fsw, fswc, sources_lw, cloud_lw, aer_lw, flw, flwc, qrs(:ncol,:), qrl(:ncol,:), cam_out%netsw(:ncol), errmsg, errflg)
+   call rrtmgp_post_run(qrs_prime(:ncol,:), qrl_prime(:ncol,:), fsns(:ncol), state%pdel(:ncol,:), atm_optics_sw, cloud_sw, &
+           aer_sw, fsw, fswc, atm_optics_lw, sources_lw, cloud_lw, aer_lw, flw, flwc, qrs(:ncol,:), qrl(:ncol,:),          &
+           cam_out%netsw(:ncol), errmsg, errflg)
    if (errflg /= 0) then
      call endrun(sub//': '//errmsg)
    end if