|
1 | 1 | =============================================================== |
2 | 2 |
|
| 3 | +Tag name: cam6_4_172 |
| 4 | +Originator(s): fvitt |
| 5 | +Date: 14 May 2026 |
| 6 | +One-line Summary: Aqueous chemistry bug fixes |
| 7 | +Github PR URL: https://github.com/ESCOMP/CAM/pull/1548 |
| 8 | + |
| 9 | +Purpose of changes (include the issue number and title text for each relevant GitHub issue): |
| 10 | + |
| 11 | +Issue #1544 |
| 12 | +Fix the following aqueous chemistry bugs: |
| 13 | + - 5th mode is not included in the updates when MAM5 is used |
| 14 | + - Failure to update NH3 when CARMA is used |
| 15 | + |
| 16 | +Describe any changes made to build system: N/A |
| 17 | + |
| 18 | +Describe any changes made to the namelist: N/A |
| 19 | + |
| 20 | +List any changes to the defaults for the boundary datasets: N/A |
| 21 | + |
| 22 | +Describe any substantial timing or memory changes: N/A |
| 23 | + |
| 24 | +Code reviewed by: cacraigucar tilmes |
| 25 | + |
| 26 | +List all files eliminated: |
| 27 | + |
| 28 | +List all files added and what they do: |
| 29 | + |
| 30 | +List all existing files that have been modified, and describe the changes: |
| 31 | +M src/chemistry/carma_aero/carma_aero_gasaerexch.F90 |
| 32 | + - initialize diagnostic varible to zero |
| 33 | + |
| 34 | +M src/chemistry/carma_aero/sox_cldaero_mod.F90 |
| 35 | + - include NH3 gas loss |
| 36 | + - enforce lower limits |
| 37 | + |
| 38 | +M src/chemistry/modal_aero/sox_cldaero_mod.F90 |
| 39 | + - include the 5th sulfate mode |
| 40 | + |
| 41 | +If there were any failures reported from running test_driver.sh on any test |
| 42 | +platform, and checkin with these failures has been OK'd by the gatekeeper, |
| 43 | +then copy the lines from the td.*.status files for the failed tests to the |
| 44 | +appropriate machine below. All failed tests must be justified. |
| 45 | + |
| 46 | +derecho/intel/aux_cam: |
| 47 | + DIFF ERP_Ld3.ne16pg3_ne16pg3_mg17.FHISTC_WAt1ma.derecho_intel.cam-reduced_hist1d |
| 48 | + DIFF ERP_Ld3.ne30pg3_ne30pg3_mt232.FHISTC_MTt4s.derecho_intel.cam-outfrq1d_aoa |
| 49 | + DIFF ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s |
| 50 | + DIFF ERP_Ln9.ne30pg3_ne30pg3_mg17.FCnudged.derecho_intel.cam-outfrq9s |
| 51 | + DIFF ERP_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WAma.derecho_intel.cam-outfrq9s |
| 52 | + DIFF ERS_Ln9.f09_f09_mg17.FX2000.derecho_intel.cam-outfrq9s |
| 53 | + DIFF ERS_Ln9.f19_f19_mg17.FXSD.derecho_intel.cam-outfrq9s |
| 54 | + DIFF ERS_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s_ctem |
| 55 | + DIFF SMS_C2_D_Ln9.ne16pg3_ne16pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s |
| 56 | + DIFF SMS_D_Ln9.f09_f09_mg17.FCts2nudged.derecho_intel.cam-outfrq9s_leapday |
| 57 | + DIFF SMS_D_Ln9.f09_f09_mg17.FCvbsxHIST.derecho_intel.cam-outfrq9s |
| 58 | + DIFF SMS_D_Ln9.f19_f19_mg17.FCARMA2000climo.derecho_intel.cam-outfrq9s |
| 59 | + DIFF SMS_D_Ln9.f19_f19_mg17.FCHIST_SLH.derecho_intel.cam-outfrq9s |
| 60 | + DIFF SMS_D_Ln9.f19_f19_mg17.FWma2000climo.derecho_intel.cam-outfrq9s |
| 61 | + DIFF SMS_D_Ln9.f19_f19_mg17.QPC2000climo.derecho_intel.cam-outfrq3s_usecase |
| 62 | + DIFF SMS_D_Ln9.ne30pg3_ne30pg3_mt232.1850C_CAM70%MT%CT4S2_CLM60%SP_CICE%PRES_DOCN%DOM_MOSART_SGLC_SWAV_SESP.derecho_intel.cam-outfrq9s |
| 63 | + DIFF SMS_D_Ln9_P1280x1.ne30pg3_ne30pg3_mt232.FHISTC_MTt1s.derecho_intel.cam-outfrq9s_Leung_dust |
| 64 | + DIFF SMS_D_Ln9_P1536x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s |
| 65 | + DIFF SMS_Ld1.f09_f09_mg17.FW2000climo.derecho_intel.cam-outfrq1d |
| 66 | + DIFF SMS_Ld1.ne30pg3_ne30pg3_mg17.FC2010climo.derecho_intel.cam-outfrq1d |
| 67 | + DIFF SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h |
| 68 | + DIFF SMS_Ln9.f09_f09_mg17.FW1850.derecho_intel.cam-reduced_hist3s |
| 69 | + DIFF SMS_Ln9.ne30pg3_ne30pg3_mg17.FW2000climo.derecho_intel.cam-outfrq9s_rrtmgp |
| 70 | + - expected differences due to bug fixes for MAM5 and CARMA |
| 71 | + |
| 72 | +derecho/nvhpc/aux_cam: PASS |
| 73 | + |
| 74 | +izumi/nag/aux_cam: |
| 75 | + FAIL ERC_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_nag.cam-outfrq3s_subcol COMPARE_base_rest |
| 76 | + - pre-existing failure -- see https://github.com/ESCOMP/CAM/issues/1514 |
| 77 | + |
| 78 | + DIFF ERC_D_Ln9.f10_f10_mg37.QPWmaC6.izumi_nag.cam-outfrq3s |
| 79 | + - expected differences due to bug fix for MAM5 |
| 80 | + |
| 81 | +izumi/gnu/aux_cam: |
| 82 | + DIFF SMS_D_Ln9.f10_f10_mg37.FWmaHIST.izumi_gnu.cam-outfrq9s_mee_fluxes |
| 83 | + - expected differences due to bug fix for MAM5 |
| 84 | + |
| 85 | +Summarize any changes to answers: |
| 86 | + larger than roundoff for MAM5 and CARMA configurations |
| 87 | + |
| 88 | +=============================================================== |
| 89 | +=============================================================== |
| 90 | + |
3 | 91 | Tag name: cam6_4_171 |
4 | 92 | Originator(s): fvitt |
5 | 93 | Date: 1 May 2026 |
|
0 commit comments