Only allow one of use_fates_inventory_init or use_fates_dbh_init to be TRUE and either only under a cold-start

[ekluzek]

Brief summary of bug

There are three initialization options under a FATES cold-start:

• inventory
• DBH
• nearly bare ground

Neither inventory or DBH should be allowed if it isn't a coldstart
And inventory AND DBH shouldn't both be allowed to be on

General bug information

CTSM version you are using: ctsm5.4.039

Does this bug cause significantly incorrect results in the model's science? No
Configurations affected: FATES cold-start

Details of bug

I tried this in a testcase:

ERS_D_Ld10.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-FatesColdNoCompInitDbh

where I changed:

CLM_FORCE_COLDSTART==off

And added settings for

finidat
fates_inventory_init (and fates_inventory_ctrl_filename)

and found there wasn't an error that came up for this. There should be two errors to prevent this:

• choosing either one with a finidat file set
• turning both on at once

[ekluzek]

As another approach to this I wonder if this should be built into CLM_FORCE_COLDSTART?

So valid_values would be:

• on
• fates_dbh
• fates_inventory
• off

Then the user wouldn't directory set use_fates_dbh_init or use_fates_inventory_init, and only deal with the CLM_FORCE_COLDSTART setting...