CN allocation tech notes improvements#4020
Merged
slevis-lmwg merged 6 commits intoMay 19, 2026
Merged
Conversation
8 tasks
8 tasks
Contributor
|
@slevis-lmwg do you mind reviewing this? |
slevis-lmwg
requested changes
May 19, 2026
slevis-lmwg
left a comment
Contributor
There was a problem hiding this comment.
@huiqi-wang thank you for your work in this PR!
- Good news, the table looks fine in the html because it has a scroll bar at the bottom.
- I requested two updates that I will try to push to the PR myself.
- Then I will merge this to b4b-dev.
…on.rst Updates to the table
This comment was marked as resolved.
This comment was marked as resolved.
…on.rst Change NF_alloc to NF_supply
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
I messed up the table. Fixing now. |
…Allocation.rst " This reverts commit 8bab0e6.
slevis-lmwg
approved these changes
May 19, 2026
slevis-lmwg
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks again @huiqi-wang.
Contributor
Author
|
Thank you for your help too!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Resolves #3866
references related:
Line 14, 16: Plant Respiration → Chapter :numref:rst_Plant Respiration
Line 14: Sprugel → :ref:Sprugel et al. (1995)Line 72: Larcher → :ref:Larcher (1995)
Line 81: Allen / Vanninen / Axelsson — all three are now :ref: Lines 72, 161: Table → :numref:Table Allocation and CN ratio parametersLines 163, 182: Equations → :eq:19.7,
:eq:19.9, :eq:19.10,:eq:19.11, :eq:19.12Lines 259, 335: FUN → Chapter :numref:rst_FUNBug fixes:
Line 72: g_l → g_1 (typo)
Line 79: parentheses fixed in the a_3 sigmoid → \frac{2.7}{1 + e^{-0.004 (NPP_{ann} - 300)}} - 0.4
Line 111: missing table row separator inserted (BDS boreal / C₃ arctic grass)
Line 194: CF_{alloc,leaf} → CF_{alloc,leaf_tot} (consistent with Eq. 19.14–19.25)
add more explanation and clarification:
Line 45: 86400 is now explained (s day⁻¹, converts τ from days to s)
Line 147: PFT abbreviation legend (NET/NDT/BET/BDT/BES/BDS + R/I)
Lines 64–70 & 154–159: Eqs. 19.7 and 19.9 use \begin{aligned} + \text{}
Line 256: section title capitalized "Nitrogen Allocation"
Line 85: table title "carbon:nitrogen" (not :)
Line 88: Target :math:CN_{...}`` (text outside math) — keep it consistant with similar item in CN Pools
- flag some but have not solved yet