Skip to content

ctsm5.4.044: Merge b4bdev 20260605#4083

Merged
ekluzek merged 178 commits into
ESCOMP:masterfrom
ekluzek:merge-b4bdev-20260605
Jun 8, 2026
Merged

ctsm5.4.044: Merge b4bdev 20260605#4083
ekluzek merged 178 commits into
ESCOMP:masterfrom
ekluzek:merge-b4bdev-20260605

Conversation

@ekluzek

@ekluzek ekluzek commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Bring latest b4b-dev to master.

Mostly updates to the documentation, especially the tech note.

Also update of submodules to almost the latest ones. This includes a few updates in cdeps to help with spinup. One specific update is to allow using the CO2 from the CPLHIST files for spinup cases. Also use daily files for CO2 CPLHIST rather than 3-hourly to sync with the change in CMEPS.

NOTE: This brings in @samsrabin update to cime that will fix the glitch we have with baselines on Izumi!

Also update the FATES parameter generation for testing

And update how the ch4 history fields are handled

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:

Any user interface changes (namelist or namelist defaults changes)?
Add cplhist option to DATM_CO2_TSERIES

** PR's Brought in**

Total 22

Changes to code: 4

Changes to documentation: 18

Changes to Tech Note: 14

Other documentation updates: 4

Testing planned or performed, if any:

  • aux_clm Derecho
  • aux_clm Izumi
  • python tests Derecho
  • build-namelist tester Derecho

(After tag is made kick off fates tests for Derecho and Izumi)

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: a
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: a

sy-li and others added 30 commits April 23, 2026 13:50
…iogeochemistry-BGC-spinup.rst


Add double quotes around module load ncl

Co-authored-by: Keith Oleson <oleson@ucar.edu>
samsrabin and others added 4 commits June 4, 2026 11:04
…of-figs-tables

Tech Note: Delete lists of figures and tables
matlab script for appending WIEMIP co2 scenario data to TRENDY2025
Overflow respiration bug fixes

PR ESCOMP#4014
Issue 3491
Changes answers in MIMICS cases only.
@ekluzek ekluzek self-assigned this Jun 5, 2026
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations labels Jun 5, 2026
@ekluzek ekluzek added documentation additions or edits to user-facing documentation or its infrastructure b4b bit-for-bit labels Jun 5, 2026
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jun 5, 2026
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jun 5, 2026

@samsrabin samsrabin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving with a brief glance, assuming it's a straightforward merge. Also assuming that the updated submodules are intentional.

@ekluzek ekluzek changed the title Merge b4bdev 20260605 ctsm5.4.044: Merge b4bdev 20260605 Jun 5, 2026
@ekluzek

ekluzek commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

I don't get how this happened. But, I assume it's just an extremly rare glitch with git. The changes to CLMBuildNamelist.pm in ctsm5.4.042 somehow got lost. git thinks they are there so I can't just remerge it in. So I have to do it more or less by hand.

Comment thread bld/CLMBuildNamelist.pm
For some reason CLMBuildNamelist.pm got screwed up and the updates in
ctsm5.4.042 backed out. git had the history and thought it was correct
so merely merging it again didn't correct it.

So I fixed it by hand by doing this:

git show {ctsm5.4.042:bld/CLMBuildNamelist.pm} > CLMBuildNamelist.pm
@ekluzek ekluzek marked this pull request as ready for review June 8, 2026 19:08
@ekluzek

ekluzek commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

The two hillslope tests that showed different answers now pass:

SMS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm60Bgc.derecho_gnu.clm-HillslopeC
SMS_D_Ld3.f10_f10_mg37.I2000Clm60Bgc.izumi_nag.clm-HillslopeD

so the testing is now as expected

@ekluzek

ekluzek commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

I think I see what happened. There was a merge of master onto @swensosc branch in PR #4057 and then a mistaken undoing of a merge that was OK here:

0fb7e1c

The b4b-dev branch already correctly had that change from ctsm5.4.042, and so didn't need it backed out. But, I also see how it's easy to get that wrong, it was basically the classic "off by one" problem we easily run into.

So then I ended up undoing the above commit. So it wasn't a glitch in git, it was a simple human mistake.

@ekluzek ekluzek moved this from Todo to Done in LMWG: Sprint Planning Board Jun 8, 2026
@slevis-lmwg

Copy link
Copy Markdown
Contributor

I think I see what happened. There was a merge of master onto @swensosc branch in PR #4057 and then a mistaken undoing of a merge that was OK here:

0fb7e1c

The b4b-dev branch already correctly had that change from ctsm5.4.042, and so didn't need it backed out. But, I also see how it's easy to get that wrong, it was basically the classic "off by one" problem we easily run into.

So then I ended up undoing the above commit. So it wasn't a glitch in git, it was a simple human mistake.

Ah, so this was another example of what I remembered this morning. A way to think about it is that we would have likely encountered significant difficulty merging to b4b-dev if we had kept the merged master in Sean's PR, so we would have reconsidered a merge to b4b-dev. Github would have also shown unexpected diffs and might have given warnings about the branch having conflicts or being inconsistent with base. In any case, I'm glad you cleared it up @ekluzek :-)

@ekluzek ekluzek merged commit 27841bd into ESCOMP:master Jun 8, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Jun 8, 2026
@ekluzek ekluzek deleted the merge-b4bdev-20260605 branch June 8, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit documentation additions or edits to user-facing documentation or its infrastructure enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations

Projects

Status: Done (non release/external)
Status: Done