You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change prescribed chemistry/aerosol schemes to use ccpp_scheme_utils; fully use diagnostic names in sima_state_diagnostics (#424)
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes',
'resolves'] and issue number):
- Change prescribed chemistry/aerosol schemes to use ccpp_scheme_utils
so they are case-insensitive - companion PR to
ESCOMP/CAM-SIMA#518
- #397 (in 979c6bc) changed
`sima_state_diagnostics` to use `%diagnostic_name` to add field but not
the write loop, so if the two cases mismatched (due to the
case-insensitivity fixes they now do) the `history_out_field` would be
mismatched and would write uninitialized heap memory into the netCDF
file rather than the variable.
List all namelist files that were added or changed:
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
main...<your_branch_name>`)
```
M schemes/chemistry/prescribed_aerosols.F90
M schemes/chemistry/prescribed_aerosols.meta
M schemes/chemistry/prescribed_ozone.F90
M schemes/chemistry/prescribed_ozone.meta
- change to use ccpp_scheme_utils.
M schemes/sima_diagnostics/sima_state_diagnostics.F90
- change to use diagnostic_name in history_out_field.
```
List all automated tests that failed, as well as an explanation for why
they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package,
algorithm change, tuning change, etc?
If yes to the above question, describe how this code was validated with
the new/modified features:
---------
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
0 commit comments