Skip to content

CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372

Open
jimmielin wants to merge 12 commits into
ESCOMP:mainfrom
jimmielin:hplin/volcrad_aero_prescribe
Open

CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372
jimmielin wants to merge 12 commits into
ESCOMP:mainfrom
jimmielin:hplin/volcrad_aero_prescribe

Conversation

@jimmielin
Copy link
Copy Markdown
Member

@jimmielin jimmielin commented Mar 12, 2026

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:
A schemes/chemistry/prescribed_volcanic_aerosol_namelist.xml

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/chemistry/prescribed_volcanic_aerosol.F90
A       schemes/chemistry/prescribed_volcanic_aerosol.meta
  - new scheme

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       test/test_suites/suite_tracer_data_test.xml
  - add to existing tracer_data BAM test

M       schemes/chemistry/prescribed_aerosol_deposition_flux.meta
M       schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml
M       schemes/chemistry/prescribed_aerosols.meta
M       schemes/chemistry/prescribed_aerosols_namelist.xml
  - fix filename_for -> filename_of to match standard names rules

List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
New physics package for the tracer data test.

If yes to the above question, describe how this code was validated with the new/modified features:
Updated snapshot; tested with CAM snapshot for correctness

@jimmielin jimmielin self-assigned this Mar 12, 2026
@jimmielin jimmielin added enhancement New feature or request aerosols Is related to aerosols (including aerosol physics and chemistry). labels Mar 12, 2026
@jimmielin jimmielin requested a review from nusbaume April 16, 2026 16:39
@jimmielin jimmielin force-pushed the hplin/volcrad_aero_prescribe branch from 3e1155e to 9b8852d Compare April 21, 2026 01:57
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this in @jimmielin! I have some change requests but hopefully nothing major, and of course if you have any questions or concerns with any of my requests then just let me know. Thanks again!

Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
Comment thread schemes/chemistry/prescribed_ozone.meta Outdated
@jimmielin jimmielin requested a review from nusbaume May 11, 2026 10:33
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my requests @jimmielin! I believe you'll need to remove const_props from the metadata file, but otherwise everything looks good to me now. Thanks again!

Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
@nusbaume nusbaume requested a review from cacraigucar May 11, 2026 21:41
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
@jimmielin jimmielin requested a review from cacraigucar May 13, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aerosols Is related to aerosols (including aerosol physics and chemistry). enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCPPize prescribed_volcaero (prescribed volcanic aerosol)

3 participants