Skip to content

CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372

Merged
jimmielin merged 12 commits into
ESCOMP:mainfrom
jimmielin:hplin/volcrad_aero_prescribe
May 18, 2026
Merged

CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372
jimmielin merged 12 commits into
ESCOMP:mainfrom
jimmielin:hplin/volcrad_aero_prescribe

Conversation

@jimmielin

@jimmielin jimmielin commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:
A schemes/chemistry/prescribed_volcanic_aerosol_namelist.xml

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/chemistry/prescribed_volcanic_aerosol.F90
A       schemes/chemistry/prescribed_volcanic_aerosol.meta
  - new scheme

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       test/test_suites/suite_tracer_data_test.xml
  - add to existing tracer_data BAM test

M       schemes/chemistry/prescribed_aerosol_deposition_flux.meta
M       schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml
M       schemes/chemistry/prescribed_aerosols.meta
M       schemes/chemistry/prescribed_aerosols_namelist.xml
  - fix filename_for -> filename_of to match standard names rules

List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
New physics package for the tracer data test.

If yes to the above question, describe how this code was validated with the new/modified features:
Updated snapshot; tested with CAM snapshot for correctness

@jimmielin jimmielin self-assigned this Mar 12, 2026
@jimmielin jimmielin added enhancement New feature or request aerosols Is related to aerosols (including aerosol physics and chemistry). labels Mar 12, 2026
@jimmielin jimmielin requested a review from nusbaume April 16, 2026 16:39
@jimmielin jimmielin force-pushed the hplin/volcrad_aero_prescribe branch from 3e1155e to 9b8852d Compare April 21, 2026 01:57

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this in @jimmielin! I have some change requests but hopefully nothing major, and of course if you have any questions or concerns with any of my requests then just let me know. Thanks again!

Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
Comment thread schemes/chemistry/prescribed_ozone.meta Outdated
@jimmielin jimmielin requested a review from nusbaume May 11, 2026 10:33

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my requests @jimmielin! I believe you'll need to remove const_props from the metadata file, but otherwise everything looks good to me now. Thanks again!

Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
@nusbaume nusbaume requested a review from cacraigucar May 11, 2026 21:41
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.F90 Outdated
Comment thread schemes/chemistry/prescribed_volcanic_aerosol.meta Outdated
@jimmielin jimmielin requested a review from cacraigucar May 13, 2026 18:18
@jimmielin jimmielin merged commit e773e04 into ESCOMP:main May 18, 2026
4 checks passed
jimmielin pushed a commit to ESCOMP/CAM-SIMA that referenced this pull request May 18, 2026
…o); update tracer_data_test snapshot (#477)

Companion PR: ESCOMP/atmospheric_physics#372

Tag name (required for release branches): sima0_13_006
Originator(s): @jimmielin 

Description (include the issue title, and the keyword ['closes',
'fixes', 'resolves'] followed by the issue number):
- Update snapshot for `prescribed_volcanic_aerosol` to be tested along
with the rest of BAM prescribed code.
- Registry entries for prescribed volcanic aerosol.
- Fixes #283 

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary
datasets):
- Updated snapshot for the BAM tracer_data test.

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
```
M       cime_config/testdefs/testmods_dirs/cam/outfrq_trcdata_bam_derecho/user_nl_cam
- Updated snapshot for the BAM tracer_data test.

M       src/data/registry.xml
- Registry entries for prescribed volcanic aerosol and derived radius

M       src/data/physconst.meta
- Fix physconst units for avogad, boltz
```

If there are new failures (compared to the
`test/existing-test-failures.txt` file),
have them OK'd by the gatekeeper, note them here, and add them to the
file.
If there are baseline differences, include the test and the reason for
the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:
```
  SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL) details:
    FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape NLCOMP
  - known failure
```

derecho/gnu/aux_sima:
```
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_trcdata_bam_derecho (Overall: DIFF) details:
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_trcdata_bam_derecho NLCOMP
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_trcdata_bam_derecho BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF
  - updated by this PR (volcanic aerosol prescribed scheme)

  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_zm_derecho (Overall: DIFF) details:
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_zm_derecho BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF
  - known failure due to science update (CAM-SIMA issue #502)

  SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam (Overall: FAIL) details:
    FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam RUN time=5
  - known FAIL on shr_reprosum_calc call from src/dynamics/se/dycore/global_norms_mod.F90
```

derecho/nvhpc/aux_sima: All PASS

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than
latest:

---------

Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aerosols Is related to aerosols (including aerosol physics and chemistry). enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCPPize prescribed_volcaero (prescribed volcanic aerosol)

4 participants