Skip to content

SIMA patch for fixing energy bug in physics-dynamics coupling#393

Open
jimmielin wants to merge 1 commit into
ESCOMP:mainfrom
jimmielin:hplin/pdc-energy-bug-fix-sima
Open

SIMA patch for fixing energy bug in physics-dynamics coupling#393
jimmielin wants to merge 1 commit into
ESCOMP:mainfrom
jimmielin:hplin/pdc-energy-bug-fix-sima

Conversation

@jimmielin
Copy link
Copy Markdown
Member

@jimmielin jimmielin commented May 13, 2026

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin (adapted from original fixes by @PeterHjortLauritzen)

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status main...<your_branch_name>)

M       schemes/conservation_adjust/check_energy/check_energy_chng.meta
M       schemes/conservation_adjust/check_energy/check_energy_scaling.meta
M       schemes/conservation_adjust/check_energy/dycore_energy_consistency_adjust.meta
M       schemes/sima_diagnostics/check_energy_diagnostics.F90
M       schemes/sima_diagnostics/check_energy_diagnostics.meta
  - update cp_or_cv_dycore and scaling_dycore standard names to add _at_start_of_physics_timestep as correctly intended

M       suites/suite_cam7.xml
M       suites/suite_kessler.xml
M       suites/suite_tj2016.xml
  - comment out thermo_water_update as it is used for not-yet-present tot_energy_phys diag.
  - add comments explaining the true purpose of mid-physics thermo_water_update.

M       suites/suite_cam4.xml
  - add missing commented thermo_water_update call to be consistent with other SDFs

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

If yes to the above question, describe how this code was validated with the new/modified features:

@jimmielin jimmielin self-assigned this May 13, 2026
@jimmielin jimmielin added the bug-fix This PR was created to fix a specific bug. label May 13, 2026
@jimmielin jimmielin requested a review from nusbaume May 13, 2026 11:30
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin!

@nusbaume nusbaume requested a review from peverwhee May 13, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This PR was created to fix a specific bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants