Complete CCPPization of UW shallow convection scheme (uwshcu)#408
Open
jimmielin wants to merge 1 commit into
Open
Complete CCPPization of UW shallow convection scheme (uwshcu)#408jimmielin wants to merge 1 commit into
jimmielin wants to merge 1 commit into
Conversation
This is a combination of 13 commits and dropped 1 commits. Initial commit. Move to atmos_phys: uw_shallow Build fixes for CAM Continue work on meta Tentative draft for meta draft diags Add convect_shallow_uw draft scheme (wrong diag scheme name) add nl file Disable check_energy for now since snapshot runs have issues (same as ZM) Add clamp_number_concentrations utility scheme. Give up on using tendencies for the number concentration clamp Various cleanup (req CAM changes) Address review comments from code review agent (claude-opus-4.6) Update CAM5 and test SDF for UW shallow Update diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin
Assisted-by: claude-opus:4.6[1m]
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
clamp_number_concentrationsutility scheme to replicate CAMphysics_types.F90behavior that clamps num* constituents to [1e-12, 1e10] range.convect_shallow_diagnostics_after_convective_evaporationinto its own scheme file (previously inlined inconvect_shallow_diagnostics) to accommodate the fact that UW does not use ZM convective evaporation.compute_cloud_fractionandrk_stratiform(cleanup)List all namelist files that were added or changed:
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
If yes to the above question, describe how this code was validated with the new/modified features: