Skip to content

Change prescribed chemistry/aerosol schemes to use ccpp_scheme_utils; fully use diagnostic names in sima_state_diagnostics#424

Merged
jimmielin merged 4 commits into
ESCOMP:mainfrom
jimmielin:hplin/case_insensitive_constituents_bug
Jul 21, 2026
Merged

Change prescribed chemistry/aerosol schemes to use ccpp_scheme_utils; fully use diagnostic names in sima_state_diagnostics#424
jimmielin merged 4 commits into
ESCOMP:mainfrom
jimmielin:hplin/case_insensitive_constituents_bug

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status main...<your_branch_name>)

M       schemes/chemistry/prescribed_aerosols.F90
M       schemes/chemistry/prescribed_aerosols.meta
M       schemes/chemistry/prescribed_ozone.F90
M       schemes/chemistry/prescribed_ozone.meta
  - change to use ccpp_scheme_utils.
 
M       schemes/sima_diagnostics/sima_state_diagnostics.F90
  - change to use diagnostic_name in history_out_field.

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

If yes to the above question, describe how this code was validated with the new/modified features:

@jimmielin jimmielin added bug-fix This PR was created to fix a specific bug. cleanup This issue indicates an opportunity for code cleanup. labels Jul 18, 2026

@climbfuji climbfuji left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this will work fine with capgen v1, too

@jimmielin
jimmielin requested a review from peverwhee July 20, 2026 13:58
@jimmielin jimmielin self-assigned this Jul 20, 2026
@jimmielin
jimmielin requested review from cacraigucar and nusbaume and removed request for peverwhee July 20, 2026 13:58

@nusbaume nusbaume left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin! I just had one optional request.

Comment thread schemes/chemistry/prescribed_aerosols.F90 Outdated

@cacraigucar cacraigucar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - interesting that ccpp_constituent_index does not return an errcode/errflag from one else section, so that you need to check for a negative const_idx after having checked for errocde.

@jimmielin
jimmielin merged commit 9865ef6 into ESCOMP:main Jul 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This PR was created to fix a specific bug. cleanup This issue indicates an opportunity for code cleanup.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants