Change prescribed chemistry/aerosol schemes to use ccpp_scheme_utils; fully use diagnostic names in sima_state_diagnostics#424
Merged
jimmielin merged 4 commits intoJul 21, 2026
Conversation
climbfuji
reviewed
Jul 19, 2026
climbfuji
left a comment
There was a problem hiding this comment.
looks like this will work fine with capgen v1, too
jimmielin
requested review from
cacraigucar and
nusbaume
and removed request for
peverwhee
July 20, 2026 13:58
nusbaume
approved these changes
Jul 20, 2026
nusbaume
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jimmielin! I just had one optional request.
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
cacraigucar
approved these changes
Jul 21, 2026
cacraigucar
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - interesting that ccpp_constituent_index does not return an errcode/errflag from one else section, so that you need to check for a negative const_idx after having checked for errocde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
sima_state_diagnosticsto use%diagnostic_nameto add field but not the write loop, so if the two cases mismatched (due to the case-insensitivity fixes they now do) thehistory_out_fieldwould be mismatched and would write uninitialized heap memory into the netCDF file rather than the variable.List all namelist files that were added or changed:
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
If yes to the above question, describe how this code was validated with the new/modified features: