[TIME001] Adjust check_time_squareness to follow sampling times guidance#63
Merged
Conversation
|
I will not have time to review the code, but I agree that
summary: I don't see a reason to prevent committing this. |
Collaborator
Author
|
For climatologies this likely still needs an update, but that could be made by a separate PR. One could have separate checks for the time-of-day and whether there are duplicate time steps, gaps, .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the sampling times guidance (currently here, but soon properly published), monthly time points can be reported at 00:00 of the first of the month, or 00:00 of the 15th of the month. In the PR I also allowed to provide monthly time points at the exact middle of the month, as first modeling centers already produced monthly time point data like this.
check_time_squarenessrequires one of these three options to be consistently applied throughout the file.To be checked if other frequency/cell_method combinations require special treatment as well.