--non-local flag not fully passed through create_test

[samsrabin]

I found myself hitting this check even when passing --non-local to create_test. This is surprising because it's under the conditional if not self._non_local:. This patch shows that non_local, which is supposed to be passed to Case.init(), is False and the NONLOCAL XML variable is unset (None):

diff --git a/CIME/case/case.py b/CIME/case/case.py
index bd6db1e50..940c77328 100644
--- a/CIME/case/case.py
+++ b/CIME/case/case.py
@@ -126,6 +126,7 @@ class Case(object):
         self.gpu_enabled = False
         self._non_local = non_local
         self.read_xml()
+        raise RuntimeError(f'\n{self._non_local=}\nNONLOCAL: {self.get_value("NONLOCAL")}')

         srcroot = self.get_value("SRCROOT")

CC @billsacks, @ekluzek

[billsacks]

Thanks for opening this @samsrabin . Just adding a bit more info: If I remember correctly, this got through create_newcase, but hit this error when doing an xmlchange. My hypothesis is that there are different paths into the Case init in those situations and that the non_local arg to the init method may not be passed correctly in the xmlchange usage... instead, the init method could maybe grab that from the existing case if that could work at this point.