docs: remove model-specific references from documentation#4976
Conversation
- Replace CESM-specific active component namelist section with generic guidance - Generalize CESM-ECT documentation to generic ECT documentation - Remove CESM-specific URLs to namelist documentation and verification website - Remove model-specific machine references (cheyenne) from examples - Generalize CESM-specific paths in examples to use placeholders - Add notes to model-specific example outputs for context - Keep model references where they provide useful context (e.g. listing CIME-driven models, historical conventions, concrete examples) Agent-Logs-Url: https://github.com/ESMCI/cime/sessions/2ef12468-32a6-42e3-a377-f05a2a354d5c Co-authored-by: jasonb5 <2191036+jasonb5@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ESMCI/cime/sessions/2ef12468-32a6-42e3-a377-f05a2a354d5c Co-authored-by: jasonb5 <2191036+jasonb5@users.noreply.github.com>
|
during meeting: some of these removals of CESM or E3SM don't help. Some of these sections need to be moved out fo CIME entirely (like how to make a new grid). Will give this a more thorough review and realize that really removing other model references will require a person to understand the context and make the decision. |
|
|
||
| 6. CESM specific: If you are adding a new atmosphere grid, this means you are also generating a new land grid, and you will need to create a new CLM surface dataset. (Otherwise you can skip this step). | ||
| You need to first generate mapping files for CLM surface dataset (since this is a non-standard grid). | ||
| 6. If you are adding a new atmosphere grid, this means you are also generating a new land grid, and you may need to create a new land surface dataset. (Otherwise you can skip this step). |
There was a problem hiding this comment.
This section no longer applies to CESM. But in fact, more generally, this whole grids section needs to be rewritten since a lot of it no longer applies to CESM.
There was a problem hiding this comment.
I have this generalized in another PR.
| --------------------------- | ||
|
|
||
| The distribution of CESM includes machines called **homebrew** and **centos7-linux** in the file **$CIMEROOT/config/cesm/machines/config_machines.xml**. | ||
| Your model distribution may include generic machine definitions (e.g., **homebrew** and **centos7-linux**) in the file **$CIMEROOT/config/$model/machines/config_machines.xml**. |
There was a problem hiding this comment.
This is no longer the correct location... it is now model-specific
There was a problem hiding this comment.
Updated to be generic and provide the user with required info to find model specific location.
| A template to create this definition is provided in **$CIMEROOT/config/xml_schemas/config_machines_template.xml**. More details are provided in the template file. | ||
| In addition, if you have a batch system, you will also need to add a **config_batch.xml** file to your **$HOME/.cime** directory. | ||
| All files in **$HOME/.cime/** are appended to the xml objects that are read into memory from the **$CIME/config/$model**, where **$model** is either ``e3sm`` or ``cesm``. | ||
| All files in **$HOME/.cime/** are appended to the xml objects that are read into memory from the **$CIME/config/$model** directory. |
There was a problem hiding this comment.
This is no longer the correct location... it is now model-specific
There was a problem hiding this comment.
Updated to be generic and provide the user with required info to find model specific location.
| After running those steps correctly, you are ready to try a case at your target compset and resolution. | ||
|
|
||
| Validating a CESM port with prognostic components | ||
| Validating a port with prognostic components |
There was a problem hiding this comment.
I feel like the removal of CESM here is misleading, since a lot of what's in this section is truly CESM (and maybe NorESM) specific. This probably needs to go in a new section that has a note that it's model-specific and still explicitly mentions CESM and maybe NorESM.
| All examples will be run from ``$CIMEROOT`` which is should exist under ``$SRCROOT`` e.g. (``$CIMEROOT`` would be ``$SRCROOT/cime``). | ||
|
|
||
| Next set the ``CIME_MODEL`` evnironment variable for your model, e.g. ``export CIME_MODEL=e3sm``. | ||
| Next set the ``CIME_MODEL`` environment variable for your model, e.g. ``export CIME_MODEL=<model>``. |
There was a problem hiding this comment.
Here and elsewhere: I'm not sure I like the replacement of specific examples with the more generic <model>: the original was pretty clear that it was just an example, and the original made it somewhat more obvious what I'd do – even for cesm – than the new version.
There was a problem hiding this comment.
I think it still better to use the placeholder, I've renamed it to <your-model> and then added a cross reference to a section to determine the users model name. I've also unified all instances of CIME_MODEL=... to use the same formatting.
| `````` | ||
|
|
||
| CIME calls **$SRCROOT/components/mosart/cime_config/buildnml** to generate the MOSART namelist variables. | ||
| <variable_name>=<value> |
There was a problem hiding this comment.
I have mixed feelings on the use of angled brackets... I feel like some people can take them too literally and actually try to put them in the file... not sure what to do here... happy to defer to other people's feelings.
There was a problem hiding this comment.
Replaced the bracket format with uppercase, it's a more common format.
|
|
||
| Sometimes when a job times out or overflows disk space, the restart files will get mangled. | ||
| With the exception of the CAM and CLM history files, all the restart files have consistent sizes. | ||
| With the exception of component history files, all the restart files have consistent sizes. |
There was a problem hiding this comment.
This clause ("With the exception of component history files") doesn't really make sense, since history files are separate from restart files.
There was a problem hiding this comment.
Updated this to only refer to restart files and check consistency between previous.
|
|
||
| ========================================== | ||
| CESM-ECT (CESM Ensemble Consistency Test): | ||
| Ensemble Consistency Test (ECT): |
There was a problem hiding this comment.
I'm not sure that removing CESM is appropriate here... but this is also probably something that belongs outside of the CIME documentation.
| $CESMDATAROOT/inputdata/validation/ensembles | ||
| $CESMDATAROOT/inputdata/validation/uf_ensembles | ||
| $CESMDATAROOT/inputdata/validation/pop_ensembles | ||
| $CIME_INPUT_DATA_ROOT/validation/ensembles |
There was a problem hiding this comment.
Is CIME_INPUT_DATA_ROOT actually a thing? I don't see references to it elsewhere, so this change feels more confusing than helpful.
There was a problem hiding this comment.
CIME_INPUT_DATA_ROOT not thing, i actually ended up reverting this entire file.
| A test mod can contain any combination of ``user_nl_*``, ``shell_commands``, ``user_mods``, or ``params.py``. | ||
|
|
||
| For example, the ``ERP`` test for an E3SM ``F-case`` can be modified to use a different radiation scheme by using ``eam-rrtmgp``:: | ||
| For example, the ``ERP`` test for an ``F-case`` can be modified to use a different radiation scheme by using ``eam-rrtmgp``:: |
There was a problem hiding this comment.
As we discussed on the call today, I actually find this clearer in the old version where it made it clear that this example applied to E3SM.
There was a problem hiding this comment.
Ok reverted this to the E3Sm specific example.
The "support a new machine" guide referenced legacy $CIMEROOT/config/$model/... paths that no longer reflect how the machines file is located (via MACHINES_SPEC_FILE in the model's config_files.xml) and described only one schema. Update paths to be model-agnostic, document the v2 (monolithic) and v3 (per-machine directory) layouts with examples, extend the xmllint snippet to cover both XSDs, and drop residual model-specific machine name examples so the page applies regardless of which model ships CIME.
The validation workflow uses the prealpha test category and pyCECT ECT tooling that target CAM/CLM/POP/CICE, which are CESM (and NorESM) constructs. Flag this up front so users of other CIME-based models look to their own documentation for the equivalent procedure.
Rename the bare <model> placeholder to <your-model> in CCS docs so readers cannot mistake it for a literal value, add a Sphinx label on the environment-setup section, and cross-reference it from the Quick Start so the valid CIME_MODEL values remain documented in a single authoritative place.
Replace angle-bracket placeholders like <variable>=<value> with ALL_CAPS tokens (VARIABLE=VALUE) so readers don't type the brackets literally. Also fix mismatched [extension] brackets in the five data model sections (DATM/DOCN/DICE/DLND/DROF).
- List all three CIME-accepted termination markers (SUCCESSFUL TERMINATION, END OF MODEL RUN, HAS ENDED) instead of just one; see TERMINATION_TEXT in CIME/case/case_run.py. - Note that the tStamp_write timing-diagnostics format is specific to MCT/cpl7-based drivers; other drivers may differ. - Replace stale external esmci.github.io URL with internal :ref: to the 'Restarting a Run' section, and add the corresponding label in running-a-case.rst.
ECT (Ensemble Consistency Test) is specific to CESM and targets CAM/CLM/POP/CICE components. Restore the original CESM-specific references, including CESMDATAROOT paths, cheyenne machine examples, and the CSEG-hosted verification web server.
The ERP F-case example with eam-rrtmgp is E3SM-specific. Restore the E3SM model reference and $E3SM source path, and clarify that pm-cpu_intel is the E3SM-specific Perlmutter CPU + Intel machine/compiler combination.
|
You can preview documentation at https://esmci.github.io/cime/branch/copilot/remove-model-references-docs/html/index.html |
Consolidate the explanation about mangled restart files into a single sentence for clarity.
Description
Remove model-specific documentation (CESM namelist URLs, CESM-ECT branding, cheyenne machine references, CESM-specific paths) while preserving model references that provide useful context for users.
Removed (not directly relevant to CIME):
setting-up-a-case.rst(CAM, CLM, CICE, POP2, CISM withcesm.ucar.eduURLs) — replaced with generic component namelist guidancetools/ect.rstandsupport-a-new-machine.rst/glade/scratch/cesm_user,$CESMDATAROOT)Generalized (relevant to CIME, made model-agnostic):
contributing-guide.rst→<model>placeholderssystem_testing.rstgrids.rstrunning-a-case.rsttroubleshooting.rstKept (provides useful context):
cime_model="cesm")Also fixes pre-existing typo:
tempororal→temporalinpes.rst.Checklist