Skip to content

Fix CRLF Injection in AsyncWebHeader.cpp (GHSA-87j8-6f7g-h8wh) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieucarbou merged 1 commit into from
Jun 29, 2025
Merged

Fix CRLF Injection in AsyncWebHeader.cpp (GHSA-87j8-6f7g-h8wh) #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/AsyncWebHeader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ AsyncWebHeader::AsyncWebHeader(const String &data) {
if (index < 0) {
return;
}
if (data.indexOf('\r') >= 0 || data.indexOf('\n') >= 0) {
// Note: do not log as info, warn or error because this could flood the logs without being able to filter this out
#ifdef ESP32
log_v("Invalid character in HTTP header");
#endif
return; // Invalid header format
}

@mathieucarbou mathieucarbou Jun 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@me-no-dev : the current code is weird IMO. If the header line cannot be parsed in anyway, we should not have created a AsyncWebHeader instance from start. This parsing logic should be extracted in a static method which is returning an AsyncWebHeader pointer or null maybe.

WDYT ?

@me-no-dev me-no-dev Jun 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could rethink the logic, agreed

@mathieucarbou mathieucarbou Jun 29, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let's merge that, cut a release, then do the change

_name = data.substring(0, index);
_value = data.substring(index + 2);
}
Expand Down