Skip to content

Correctly support ESP8266 for examples and default filters#344

Merged
mathieucarbou merged 1 commit into
mainfrom
exemples-8266
Nov 25, 2025
Merged

Correctly support ESP8266 for examples and default filters#344
mathieucarbou merged 1 commit into
mainfrom
exemples-8266

Conversation

@mathieucarbou

@mathieucarbou mathieucarbou commented Nov 25, 2025

Copy link
Copy Markdown
Member

This PR allows to run examples on esp8266 (WiFi was not activated).

It also corrects the default filters ON_STA_FILTER and ON_AP_FILTER

@coderabbitai

coderabbitai Bot commented Nov 25, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch exemples-8266

Comment @coderabbitai help to get the list of available commands and usage tips.

@willmmiles

Copy link
Copy Markdown

We really need to pull that test in to a single macro in a shared header..

@mathieucarbou

Copy link
Copy Markdown
Member Author

We really need to pull that test in to a single macro in a shared header..

yes indeed... 😅

@mathieucarbou

Copy link
Copy Markdown
Member Author

We really need to pull that test in to a single macro in a shared header..

done ;-)

@mathieucarbou mathieucarbou merged commit 8dd3167 into main Nov 25, 2025
33 checks passed
@mathieucarbou mathieucarbou deleted the exemples-8266 branch November 25, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants