Minor fixes

- Fixed an issue with the classifier factory throwing an exception with ASPX files.  Fixes #287.
- Fixed a couple of issues when adding and removing sections in the configuration editor.  Fixes #293.
- Fixed handling of all uppercase words in the word splitter when they are being spell checked.

Author: EWSoftware

Source/VSSpellCheckerCommon/EditorConfig/EditorConfigSection.cs

@@ -142,7 +142,7 @@ public EditorConfigSection()
         /// <param name="lines">An enumerable list of section lines</param>
         public EditorConfigSection(IEnumerable<SectionLine> lines)
         {
-            this.SectionLines = new Collection<SectionLine>(lines.ToArray());
+            this.SectionLines = new Collection<SectionLine>(lines.ToList());
         }
 
         /// <summary>

Source/VSSpellCheckerCommon/WordSplitter.cs

@@ -2,7 +2,7 @@
 // System  : Visual Studio Spell Checker Package
 // File    : WordSplitter.cs
 // Authors : Noah Richards, Roman Golovin, Michael Lehenbauer, Eric Woodruff
-// Updated : 03/12/2023
+// Updated : 06/14/2023
 // Note    : Copyright 2010-2023, Microsoft Corporation, All rights reserved
 //           Portions Copyright 2013-2023, Eric Woodruff, All rights reserved
 //
@@ -542,7 +542,7 @@ public IEnumerable<T> GetWordsInText(string text)
                             }
                             else
                             {
-                                int split = i;
+                                int split = i, start = i;
 
                                 while(split < end)
                                 {
@@ -551,6 +551,13 @@ public IEnumerable<T> GetWordsInText(string text)
                                     while(split + 1 < end && Char.IsUpper(text[split + 1]))
                                         split++;
 
+                                    // If all uppercase, return the entire word
+                                    if(i == start && split == end - 1)
+                                    {
+                                        yield return this.CreateSpan(i, end);
+                                        break;
+                                    }
+
                                     i = split;
                                     split++;
 

Source/VSSpellCheckerShared/Editors/SpellingConfigurationEditorControl.xaml.cs

@@ -2,7 +2,7 @@
 // System  : Visual Studio Spell Checker Package
 // File    : SpellConfigurationEditorControl.xaml.cs
 // Author  : Eric Woodruff  (Eric@EWoodruff.us)
-// Updated : 05/15/2023
+// Updated : 06/15/2023
 // Note    : Copyright 2015-2023, Eric Woodruff, All rights reserved
 //
 // This file contains a user control used to edit spell checker configuration settings files
@@ -363,8 +363,14 @@ private void btnDeleteSection_Click(object sender, RoutedEventArgs e)
                 int idx = lbSections.SelectedIndex;
 
                 lastSelectedSection = -1;
+
                 sections.RemoveAt(idx);
-                configFile.Sections.RemoveAt(idx);
+
+                // Adjust the index when there is a root section
+                if(configFile.Sections[0].IsRoot)
+                    configFile.Sections.RemoveAt(idx + 1);
+                else
+                    configFile.Sections.RemoveAt(idx);
 
                 if(lbSections.Items.Count <= idx)
                     idx--;
@@ -443,8 +449,18 @@ private void btnMoveUpDown_Click(object sender, RoutedEventArgs e)
                 sections.RemoveAt(currentIndex);
                 sections.Insert(newIndex, sectionToMove);
 
-                configFile.Sections.RemoveAt(currentIndex);
-                configFile.Sections.Insert(newIndex, sectionToMove.Section);
+                // Adjust the index when there is a root section
+                if(configFile.Sections[0].IsRoot)
+                {
+                    configFile.Sections.RemoveAt(currentIndex + 1);
+                    configFile.Sections.Insert(newIndex + 1, sectionToMove.Section);
+                }
+                else
+                {
+                    configFile.Sections.RemoveAt(currentIndex);
+                    configFile.Sections.Insert(newIndex, sectionToMove.Section);
+                }
+
                 suppressSectionChange = false;
 
                 lbSections.SelectedIndex = newIndex;

Source/VSSpellCheckerShared/ProjectSpellCheck/ClassifierFactory.cs

@@ -2,7 +2,7 @@
 // System  : Visual Studio Spell Checker Package
 // File    : ClassifierFactory.cs
 // Author  : Eric Woodruff  (Eric@EWoodruff.us)
-// Updated : 03/22/2023
+// Updated : 06/15/2023
 // Note    : Copyright 2015-2023, Eric Woodruff, All rights reserved
 //
 // This file contains a class used to generate classifiers for files that need to be spell checked
@@ -149,6 +149,9 @@ public static bool IsCStyleCode(string filename)
         /// <returns>True if it does, false if not</returns>
         public static bool SupportsOldStyleXmlDocComments(string filename)
         {
+            if(filename == null)
+                return false;
+
             string extension = Path.GetExtension(filename);
 
             if(extensionMap == null)