[FTD #5] support underline for multiple lines of text#11
Merged
Conversation
TobiasRump
force-pushed
the
bugfix/FTD-5-underlined-text-multiple-lines
branch
3 times, most recently
from
ab00aa9 to
8e423cc
Compare
TobiasRump
force-pushed
the
bugfix/FTD-5-underlined-text-multiple-lines
branch
4 times, most recently
from
32c0a1e to
e68fe29
Compare
TobiasRump
force-pushed
the
bugfix/FTD-5-underlined-text-multiple-lines
branch
from
e68fe29 to
3daa8f5
Compare
jay-k98
approved these changes
Jun 13, 2025
Collaborator
There was a problem hiding this comment.
Can you please add a golden test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Fix: Multi-line underline rendering issue
📌 Related Issue
Closes #5
✅ What’s Changed
This PR updates the underline styling logic to ensure that multi-line text is consistently underlined line by line. Previously, only the final line received the underline styling, leading to inconsistent and visually incorrect results.
Additionally, I increased a little more the curve for line. There is the opportunity to set it from outside how curved the line should be displayed.
🧪 How It Works
Instead of applying a single underline across a block of multi-line text, we ensure line breaks do not break the underline visual appearance.
🔍 Confirmation
📸 Before / After