Skip to content

Feature/box padding local#13

Merged
jay-k98 merged 3 commits into
mainfrom
feature/box-padding-local
Jun 13, 2025
Merged

Feature/box padding local#13
jay-k98 merged 3 commits into
mainfrom
feature/box-padding-local

Conversation

@jay-k98
Copy link
Copy Markdown
Collaborator

@jay-k98 jay-k98 commented Jun 12, 2025

📌 Related Issue
Closes: #6

The box decoration currently offers no option to increase the padding between text and box itself. This leads to the boxe's borders being directly stuck to the text, which also leads to some letters being partly outside the box. See the screenshot i.e. the "q" of "quer" is partly outside the box.

✅ What’s Changed
This PR enables users to define a Padding via EdgeInsets for the Box Painters (RoundedBoxPainter, // TODO...)

🧪 How It Works
Calculate the new offset center using the EdgeInsets

🔍 Confirmation

  • Padding is applied correctly, even for different values
    • e.g. EdgeInsets.only(left: 4, top: 8, right: 16, bottom: 24).

📸 Before / After

Before After
Bildschirmfoto 2025-06-12 um 15 54 00

@jay-k98 jay-k98 requested a review from TobiasRump June 12, 2025 13:54
Comment thread .vscode/settings.json Outdated
Comment thread example/android/app/build.gradle
Comment thread example/android/settings.gradle
@TobiasRump
Copy link
Copy Markdown
Collaborator

please revert android changes @jay-k98

@jay-k98 jay-k98 force-pushed the feature/box-padding-local branch from 72cd176 to 122dcd5 Compare June 12, 2025 18:02
@jay-k98 jay-k98 force-pushed the feature/box-padding-local branch 3 times, most recently from f9153a9 to 4057692 Compare June 13, 2025 07:30
jay-k98 added 2 commits June 13, 2025 09:35
Signed-off-by: Jonas Klock <jonas.klock@exxeta.com>
Signed-off-by: Jonas Klock <jonas.klock@exxeta.com>
@jay-k98 jay-k98 force-pushed the feature/box-padding-local branch from 4057692 to a9e7207 Compare June 13, 2025 07:36
@TobiasRump TobiasRump force-pushed the feature/box-padding-local branch 2 times, most recently from 2a9dcf1 to a9166d6 Compare June 13, 2025 09:36
@TobiasRump TobiasRump force-pushed the feature/box-padding-local branch from a9166d6 to 5e48c80 Compare June 13, 2025 09:43
Copy link
Copy Markdown
Collaborator

@TobiasRump TobiasRump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jay-k98 jay-k98 merged commit 350717e into main Jun 13, 2025
1 check passed
@TobiasRump TobiasRump deleted the feature/box-padding-local branch September 3, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Box decoration: padding

2 participants