feat(196): Support importing Bruno Collections#773
Draft
giemic8 wants to merge 7 commits into
Draft
Conversation
9c3bc83 to
98155e7
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ohm-js (used by @usebruno/lang) cannot be correctly bundled by Rollup into a CJS output — ohm.grammar ends up undefined at runtime. Making @usebruno/lang external causes Electron to require() it directly from node_modules at runtime, where it works correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
98155e7 to
06abf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Changes
Implements
BrunoImporterto support importing Bruno collections into Trufos (closes #196).bruno-importer.ts— New importer using@usebruno/lang(official Bruno parser):bruno.json.brufiles → requestsseqordering from the meta blockjson,text,xml,multipartForm,formUrlEncoded,filebearer,basic,inherit,oauth2(client_credentials, authorization_code, PKCE)params:queryblockenvironments/subdirectorybruno-types.d.ts— TypeScript declarations for the JS-only@usebruno/langpackageimport-service.ts— RegistersBrunoImporterunder the'Bruno'strategyCollectionImport.tsx— Replaces "Coming soon..." with a working Bruno import UI (directory picker → target dir → title → Import)@usebruno/langdependencyTesting
16 automated tests in
bruno-importer.test.tscovering:params:queryblockseq-based orderingenvironments/directorybruno.jsonfile path as inputChecklist
PR Type
Enhancement, Tests
Description
Implement
BrunoImporterfor Bruno collectionsSupport HTTP methods, bodies, auth, query, environments
Register Bruno strategy and update build config
Enable Bruno import UI and comprehensive tests
File Walkthrough
1 files
Add tests for BrunoImporter functionality3 files
Implement BrunoImporter for Bruno collectionsRegister BrunoImporter in ImportServiceAdd Bruno import UI with directory pickers1 files
Add type declarations for @usebruno/lang1 files
Exclude @usebruno/lang from Rollup bundle1 files
Add @usebruno/lang dependency