Skip to content

Commit 06d3da1

Browse files
committed
Declare allowed secret names to allow loading environmental values
The way environment secrets and var work is a bit wonky, but without these being declared, even though the secrets themselves are defined in the caller repo's environment, the values were just empty. I don't think the caller has to explicitly pass them in (as they can't be resolved without an `environment` delcaration anyway), so I'm hoping just making them not required will be okay, and we'll leave our actual safety checks in place to validate that we have something.
1 parent 9a90b9e commit 06d3da1

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

.github/workflows/draft-release-flutter.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,25 @@ on:
3030
required: false
3131
type: string
3232
default: upload
33+
secrets:
34+
ANDROID_APP_SIGNING_KEYSTORE_B64:
35+
required: false
36+
ANDROID_APP_SIGNING_KEYSTORE_PASSWORD:
37+
required: false
38+
ANDROID_APP_SIGNING_KEY_PASSWORD:
39+
required: false
40+
ANDROID_UPLOAD_KEYSTORE_B64:
41+
required: false
42+
ANDROID_UPLOAD_KEYSTORE_PASSWORD:
43+
required: false
44+
ANDROID_UPLOAD_KEY_PASSWORD:
45+
required: false
46+
IOS_SIGNING_CERT_B64:
47+
required: false
48+
IOS_SIGNING_CERT_PASSWORD:
49+
required: false
50+
IOS_PROVISIONING_PROFILE_B64:
51+
required: false
3352

3453
permissions:
3554
contents: read

.github/workflows/upload-build-ios.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ on:
77
release_tag:
88
required: true
99
type: string
10+
secrets:
11+
ASC_AUTH_KEY_B64:
12+
required: false
1013

1114
jobs:
1215
upload_build:

0 commit comments

Comments
 (0)