Skip to content

Commit c5b585f

Browse files
committed
Add descriptions back to workflow_call secret declarations
We removed these when I thouht we could just read environmental secrets without having these defined at the top, but it turns out we do need them defined, so we'll leave the doc here with the additional details in the docs/flutter.md file. We don't need the vars defined as inputs though, I believe.
1 parent 06d3da1 commit c5b585f

2 files changed

Lines changed: 25 additions & 3 deletions

File tree

.github/workflows/draft-release-flutter.yml

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,42 @@ on:
3232
default: upload
3333
secrets:
3434
ANDROID_APP_SIGNING_KEYSTORE_B64:
35-
required: false
35+
description: >
36+
Base64-encoded Android app signing keystore (PKCS12 or JKS) used by
37+
Gradle to sign release APKs in CI.
38+
required: true
3639
ANDROID_APP_SIGNING_KEYSTORE_PASSWORD:
37-
required: false
40+
description: >
41+
Password protecting the Android app signing keystore file.
42+
required: true
3843
ANDROID_APP_SIGNING_KEY_PASSWORD:
39-
required: false
44+
description: >
45+
Password for the app signing key alias within the Android keystore.
46+
required: true
4047
ANDROID_UPLOAD_KEYSTORE_B64:
48+
description: >
49+
Base64-encoded Android upload keystore (PKCS12 or JKS) used by
50+
Gradle to sign release App Bundles in CI.
4151
required: false
4252
ANDROID_UPLOAD_KEYSTORE_PASSWORD:
53+
description: >
54+
Password protecting the Android upload keystore file.
4355
required: false
4456
ANDROID_UPLOAD_KEY_PASSWORD:
57+
description: >
58+
Password for the upload key alias within the Android keystore.
4559
required: false
4660
IOS_SIGNING_CERT_B64:
61+
description: >
62+
Base64-encoded iOS distribution signing certificate (P12) used for App Store builds.
4763
required: false
4864
IOS_SIGNING_CERT_PASSWORD:
65+
description: >
66+
Password protecting the iOS signing certificate.
4967
required: false
5068
IOS_PROVISIONING_PROFILE_B64:
69+
description: >
70+
Base64-encoded iOS provisioning profile for App Store builds.
5171
required: false
5272

5373
permissions:

.github/workflows/upload-build-ios.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ on:
99
type: string
1010
secrets:
1111
ASC_AUTH_KEY_B64:
12+
description: >
13+
Base64-encoded AuthKey file (.p8) used for App Store Connect API JWT authentication.
1214
required: false
1315

1416
jobs:

0 commit comments

Comments
 (0)