Declare allowed secret names to allow loading environmental values#190
Merged
Conversation
The way environment secrets and var work is a bit wonky, but without these being declared, even though the secrets themselves are defined in the caller repo's environment, the values were just empty. I don't think the caller has to explicitly pass them in (as they can't be resolved without an `environment` delcaration anyway), so I'm hoping just making them not required will be okay, and we'll leave our actual safety checks in place to validate that we have something.
elasticdog
enabled auto-merge
February 15, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way environment secrets and var work is a bit wonky, but without these being declared, even though the secrets themselves are defined in the caller repo's environment, the values were just empty. I don't think the caller has to explicitly pass them in (as they can't be resolved without an
environmentdelcaration anyway), so I'm hoping just making them not required will be okay, and we'll leave our actual safety checks in place to validate that we have something.