ci: add dedicated ModSecurity v3 warn-only hardening build job#110
Merged
Easton97-Jens merged 1 commit intoMay 15, 2026
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
-Werror/-Werror=format-securityso warnings are shown without turning failures into noisy cut-offs.Description
build-modsecurity-v3to.github/workflows/ci_new.ymlthat runs onubuntu-24.04and does not replace existing matrix jobs.COMMON_CC_OPT,COMMON_LD_OPT,PIC_CC_OPT,MODSECURITY_CC_OPT,MODSECURITY_CXX_OPT, andMODSECURITY_LD_OPTand explicitly enables-Wall -Wextra -Wformat -Wformat-securityfor ModSecurity.MODSECURITY_WARN_ONLY=1and strips any-Werror/-Werror=format-securityfrom the ModSecurity warning flags when set so warnings remain visible but real compile/link errors still fail the job.CFLAGS,CXXFLAGS,CPPFLAGS, andLDFLAGS, include-fPIC, and enable linker hardening with-Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -Wl,--as-needed -Wl,--gc-sections; the job avoids adding LuaJIT rpath or nginx/OpenResty-specific flags.CFLAGS,CXXFLAGS,CPPFLAGS,LDFLAGSand configure options to the CI log before running./configureand builds with verbose output viamake -j "$(nproc)" V=1.Testing
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci_new.yml")', which completed successfully..github/workflows/ci_new.ymland the file was checked locally for syntactic correctness (YAML load succeeded).Codex Task