Avoid eager SQLi/XSS debug input formatting#111
Open
Easton97-Jens wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
DetectSQLi::evaluateandDetectXSS::evaluate, which bypassed the runtime debug-level guard and could cause avoidable CPU and memory usage.Description
loggable_inputfromsrc/operators/detect_sqli.ccandsrc/operators/detect_xss.ccto avoid always callingtoHexIfNeededon the full input.utils::string::limitTo(80, utils::string::toHexIfNeeded(input))directly inside thems_dbg_a(...)message expressions so the existing lazy runtime debug-level check inms_dbg_aprevents formatting when logging is disabled.Testing
git -C /workspace/ModSecurity diff --checkwhich passed.git -C /workspace/ModSecurity status --shortand inspected the updated source withnl -bato confirm the inlined formatting expressions were applied toDetectSQLiandDetectXSSand no other files were modified.Codex Task