Restore SecDefaultAction inheritance for rules without explicit disruptive action#113
Open
Easton97-Jens wants to merge 1 commit into
Open
Restore SecDefaultAction inheritance for rules without explicit disruptive action#113Easton97-Jens wants to merge 1 commit into
Easton97-Jens wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
SecDefaultActiondisruptive execution on acontainsBlockflag which caused matching rules that do not define their own disruptive action to become detection-only; this patch restores the expected behavior so default disruptive actions still apply unless the rule explicitly provides its own disruptive action.Description
RuleWithActions::executeActioninsrc/rule_with_actions.ccto skip default disruptive actions only when the rule already has an explicit disruptive action (m_disruptiveAction != nullptrand its name is not"block"), and update the debug message to reflect this condition.Testing
test/regression_tests) but the test binary is not present in this environment, so no automated regression tests were executed here.Codex Task