Skip to content

Restore SecDefaultAction inheritance for rules without explicit disruptive action#113

Open
Easton97-Jens wants to merge 1 commit into
v3/masterfrom
codex/fix-default-blocking-action-logic-k65htg
Open

Restore SecDefaultAction inheritance for rules without explicit disruptive action#113
Easton97-Jens wants to merge 1 commit into
v3/masterfrom
codex/fix-default-blocking-action-logic-k65htg

Conversation

@Easton97-Jens
Copy link
Copy Markdown
Owner

Motivation

  • A recent change gated SecDefaultAction disruptive execution on a containsBlock flag which caused matching rules that do not define their own disruptive action to become detection-only; this patch restores the expected behavior so default disruptive actions still apply unless the rule explicitly provides its own disruptive action.

Description

  • Modify RuleWithActions::executeAction in src/rule_with_actions.cc to skip default disruptive actions only when the rule already has an explicit disruptive action (m_disruptiveAction != nullptr and its name is not "block"), and update the debug message to reflect this condition.

Testing

  • Attempted to run the regression harness (test/regression_tests) but the test binary is not present in this environment, so no automated regression tests were executed here.

Codex Task

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant