Fix parser differential caused by URI fragment truncation#115
Open
Easton97-Jens wants to merge 1 commit into
Open
Fix parser differential caused by URI fragment truncation#115Easton97-Jens wants to merge 1 commit into
Easton97-Jens wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
#in the request-target are removed fromREQUEST_URI,QUERY_STRING, andARGS_GETwhile backends/connectors may still see them.#is not hidden from standard ModSecurity variables.Description
#inTransaction::processURIso subsequent decoding and query extraction use the full received request-target (src/transaction.cc).processURIsoREQUEST_URI_RAWandREQUEST_LINEbehavior is unchanged whileREQUEST_URI,QUERY_STRING, andARGS_GETare populated from the full URI.Testing
others/libinjectionsubmodule, preventing running the repository's full regression harness, so CI/regression tests should be run externally after this change.Codex Task