Fix @rbl false-negative when getaddrinfo returns IPv6 first#116
Open
Easton97-Jens wants to merge 1 commit into
Open
Fix @rbl false-negative when getaddrinfo returns IPv6 first#116Easton97-Jens wants to merge 1 commit into
Easton97-Jens wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
Rbl::evaluate()wheregetaddrinfo()could return anAF_INET6entry before a validAF_INETRBL response and the code returnedfalseafter inspecting only the firstaddrinfo, causing possible fail-open behavior for@rblrules.Description
addrinfolinked list returned bygetaddrinfo()and select the firstAF_INETentry to populate thesockaddr_inand callfurtherInfo(); only returnfalseafter scanning all results and finding no IPv4 entry (changes insrc/operators/rbl.cc).Testing
test -d build, attemptedcmake --build build -j2 --target modsecurity(failed withError: could not load cachedue to local build cache/config state), and verified the source diff and affected lines withgit diffandnl -ba src/operators/rbl.ccto confirm the intended change.Codex Task