minor #7237 use the IdentityTranslator instead of a custom TranslatorInterface mock (xabbuh)

This PR was merged into the 4.x branch.

Discussion
----------

use the IdentityTranslator instead of a custom TranslatorInterface mock

Commits
-------

aa897df use the IdentityTranslator instead of a custom TranslatorInterface mock

Author: javiereguiluz

tests/Factory/FieldFactoryTest.php

@@ -15,7 +15,7 @@
 use EasyCorp\Bundle\EasyAdminBundle\Tests\TestApplication\Entity\ProjectDomain\Project;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
-use Symfony\Contracts\Translation\TranslatorInterface;
+use Symfony\Component\Translation\IdentityTranslator;
 
 class FieldFactoryTest extends KernelTestCase
 {
@@ -31,14 +31,11 @@ protected function setUp(): void
         $authorizationCheckerInterface = $this->getMockBuilder(AuthorizationCheckerInterface::class)->disableOriginalConstructor()->getMock();
         $authorizationCheckerInterface->method('isGranted')->willReturn(true);
 
-        $translatorMock = $this->createMock(TranslatorInterface::class);
-        $translatorMock->method('trans')->willReturnArgument(0);
-
         $this->fieldFactory = new FieldFactory(
             $this->getMockBuilder(AdminContextProviderInterface::class)->disableOriginalConstructor()->getMock(),
             $authorizationCheckerInterface,
             [],
-            new FormLayoutFactory($translatorMock),
+            new FormLayoutFactory(new IdentityTranslator()),
         );
     }
 

tests/Factory/FormLayoutFactoryTest.php

@@ -18,7 +18,7 @@
 use EasyCorp\Bundle\EasyAdminBundle\Form\Type\Layout\EaFormTabPaneGroupCloseType;
 use EasyCorp\Bundle\EasyAdminBundle\Form\Type\Layout\EaFormTabPaneGroupOpenType;
 use PHPUnit\Framework\TestCase;
-use Symfony\Contracts\Translation\TranslatorInterface;
+use Symfony\Component\Translation\IdentityTranslator;
 
 class FormLayoutFactoryTest extends TestCase
 {
@@ -30,10 +30,7 @@ public function testFixFormColumns(array $fieldConfig, string $expectedLayout)
         $originalFields = $this->createFormFieldsFromConfig($fieldConfig);
         $expectedFields = $this->createFormFieldsFromLayout($expectedLayout);
 
-        $translatorMock = $this->createMock(TranslatorInterface::class);
-        $translatorMock->method('trans')->willReturnArgument(0);
-
-        $formLayoutFactory = new FormLayoutFactory($translatorMock);
+        $formLayoutFactory = new FormLayoutFactory(new IdentityTranslator());
         $formLayoutFactory->createLayout($originalFields, Crud::PAGE_EDIT);
 
         $this->assertTrue($this->isFormLayoutTheSame($expectedFields, $originalFields));
@@ -49,10 +46,7 @@ public function testFixFormColumnsErrors(array $originalFields, string $expected
 
         $originalFields = $this->createFormFieldsFromConfig($originalFields);
 
-        $translatorMock = $this->createMock(TranslatorInterface::class);
-        $translatorMock->method('trans')->willReturnArgument(0);
-
-        $fieldFactory = new FormLayoutFactory($translatorMock);
+        $fieldFactory = new FormLayoutFactory(new IdentityTranslator());
         $fieldFactory->createLayout($originalFields, Crud::PAGE_EDIT);
     }
 

tests/Form/Type/CrudFormTypeFormFormFieldTest.php

@@ -11,7 +11,7 @@
 use Symfony\Bridge\Doctrine\Form\DoctrineOrmTypeGuesser;
 use Symfony\Component\Form\PreloadedExtension;
 use Symfony\Component\Form\Test\TypeTestCase;
-use Symfony\Contracts\Translation\TranslatorInterface;
+use Symfony\Component\Translation\IdentityTranslator;
 
 class CrudFormTypeFormFormFieldTest extends TypeTestCase
 {
@@ -81,12 +81,9 @@ private function getEntityDto(array $fields): EntityDto
             ->method('getFqcn')
             ->willReturn(_TestEntity::class);
 
-        $translatorMock = $this->createMock(TranslatorInterface::class);
-        $translatorMock->method('trans')->willReturnArgument(0);
-
         $mock
             ->method('getFields')
-            ->willReturn((new FormLayoutFactory($translatorMock))
+            ->willReturn((new FormLayoutFactory(new IdentityTranslator()))
                 ->createLayout(FieldCollection::new($fields), Crud::PAGE_NEW)
             );