Fix property access for field mapping type#7223
Draft
Chris53897 wants to merge 7 commits intoEasyCorp:4.xfrom
Draft
Fix property access for field mapping type#7223Chris53897 wants to merge 7 commits intoEasyCorp:4.xfrom
Chris53897 wants to merge 7 commits intoEasyCorp:4.xfrom
Conversation
Contributor
Author
|
I have converted it to draft. |
| $fieldMapping = $entityDto->getClassMetadata()->getFieldMapping($propertyName); | ||
|
|
||
| return self::$doctrineTypeToFilterClass[$fieldMapping['type']] ?? TextFilter::class; | ||
| if (version_compare(InstalledVersions::getVersion('doctrine/orm'), '3.0', '<')) { |
Collaborator
There was a problem hiding this comment.
This is the fix we use in other parts of the code:
EasyAdminBundle/src/Orm/EntityRepository.php
Lines 301 to 310 in e373893
It's a bit convoluted 😐 but it covers Doctrine ORM 2.x, 3.x and 4.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will address
19x: Using ArrayAccess on Doctrine\ORM\Mapping\FieldMapping is deprecated and will not be possible in Doctrine ORM 4.0. Use the corresponding property instead. (ArrayAccessImplementation.php:31 called by FieldFactory.php:180, https://github.com/doctrine/orm/pull/11211, package doctrine/orm)