Skip to content

Fix fieldset margins #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seb33300 wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Fix fieldset margins #7482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions assets/css/easyadmin-theme/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,11 @@ label.form-check-label {
}

/* Form columns */
.form-column {
display: flex;
flex-direction: column;
gap: var(--bs-gutter-x);
}
.form-column .form-column-title {
display: flex;
flex-direction: column;
Expand All @@ -381,9 +386,6 @@ label.form-check-label {
flex: 1;
margin: 0;
}
.form-column .field-form_fieldset {
margin-block-end: var(--bs-gutter-x);
}

.form-column .form-fieldset {
border-radius: var(--border-radius);
Expand Down Expand Up @@ -412,10 +414,6 @@ label.form-check-label {
}

/* Form fieldsets */
.field-form_fieldset {
margin-block-end: calc(1.5 * var(--bs-gutter-x)); /* not a typo; don't use --bs-gutter-y here */
}

.form-section-empty {
padding: 25px 10px 25px;
}
Expand Down
4 changes: 2 additions & 2 deletions templates/crud/detail.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@
</div>
{% endif %}

<div class="row">
<div class="row g-4">
{% endmacro %}

{% macro render_tab_close(field) %}
Expand All @@ -183,7 +183,7 @@
{% macro render_column_group_open(field) %}
{# if columns are inside tabs, don't add a '.row' element because the tab pane already opens it #}
{% if not field.getFormTypeOption('ea_is_inside_tab')|default(false) %}
<div class="row">
<div class="row g-4">
{% endif %}
{% endmacro %}

Expand Down
4 changes: 2 additions & 2 deletions templates/crud/form_theme.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@
{% block ea_form_column_group_open_row %}
{# if columns are inside tabs, don't add a '.row' element because the tab pane already opens it #}
{% if not form.vars.ea_is_inside_tab|default(false) %}
<div class="row">
<div class="row g-4">
{% endif %}
{% endblock ea_form_column_group_open_row %}

Expand Down Expand Up @@ -599,7 +599,7 @@
</div>
{% endif %}

<div class="row">
<div class="row g-4">
{% endblock ea_form_tabpane_open_row %}

{% block ea_form_tabpane_close_row %}
Expand Down
Loading