Skip to content

Remove dead code and simplify redundant constructs#7709

Open
guillaume-sainthillier wants to merge 1 commit into
EasyCorp:5.xfrom
guillaume-sainthillier:remove-dead-code-and-simplify
Open

Remove dead code and simplify redundant constructs#7709
guillaume-sainthillier wants to merge 1 commit into
EasyCorp:5.xfrom
guillaume-sainthillier:remove-dead-code-and-simplify

Conversation

@guillaume-sainthillier

Copy link
Copy Markdown
Contributor
  • remove the unused Doctrine FieldMapping imports left over from the
    DBAL 3/4 compatibility work
  • remove AdminContextFactory's duplicated getUser() call and the unused
    $request parameter of getDashboardDto()
  • remove the unused $entityDto parameter of
    CommonPreConfigurator::buildTemplatePathOption()
  • return expressions directly instead of assigning them to a variable
    used only once (SearchDto, MenuFactory, MenuItemMatcher,
    ComparisonType)
  • flatten the nested null/Stringable checks in
    CrudDto::getDefaultPageTitle() and use the nullsafe operator in
    AdminContextFactory

- remove the unused Doctrine FieldMapping imports left over from the
  DBAL 3/4 compatibility work
- remove AdminContextFactory's duplicated getUser() call and the unused
  $request parameter of getDashboardDto()
- remove the unused $entityDto parameter of
  CommonPreConfigurator::buildTemplatePathOption()
- return expressions directly instead of assigning them to a variable
  used only once (SearchDto, MenuFactory, MenuItemMatcher,
  ComparisonType)
- flatten the nested null/Stringable checks in
  CrudDto::getDefaultPageTitle() and use the nullsafe operator in
  AdminContextFactory
@guillaume-sainthillier
guillaume-sainthillier force-pushed the remove-dead-code-and-simplify branch from 1265d05 to f39621f Compare July 13, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant