Remove dead code and simplify redundant constructs#7709
Open
guillaume-sainthillier wants to merge 1 commit into
Open
Remove dead code and simplify redundant constructs#7709guillaume-sainthillier wants to merge 1 commit into
guillaume-sainthillier wants to merge 1 commit into
Conversation
- remove the unused Doctrine FieldMapping imports left over from the DBAL 3/4 compatibility work - remove AdminContextFactory's duplicated getUser() call and the unused $request parameter of getDashboardDto() - remove the unused $entityDto parameter of CommonPreConfigurator::buildTemplatePathOption() - return expressions directly instead of assigning them to a variable used only once (SearchDto, MenuFactory, MenuItemMatcher, ComparisonType) - flatten the nested null/Stringable checks in CrudDto::getDefaultPageTitle() and use the nullsafe operator in AdminContextFactory
guillaume-sainthillier
force-pushed
the
remove-dead-code-and-simplify
branch
from
July 13, 2026 07:33
1265d05 to
f39621f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBAL 3/4 compatibility work
$request parameter of getDashboardDto()
CommonPreConfigurator::buildTemplatePathOption()
used only once (SearchDto, MenuFactory, MenuItemMatcher,
ComparisonType)
CrudDto::getDefaultPageTitle() and use the nullsafe operator in
AdminContextFactory