Commit 69bfdc1
committed
feat(nginx-proxy): Implement ssl_reject_handshake for missing certificates
Instead of serving 500 errors with default certificates when a vhost
has no valid SSL certificate, nginx now:
1. Uses default certificate (if available) and returns 503
2. Rejects the SSL/TLS handshake entirely (if no default cert)
Benefits:
- Prevents certificate warning dialogs in browsers
- More secure - doesn't expose invalid/default certificates
- Cleaner failure mode for unknown hosts
- Matches upstream jwilder/nginx-proxy behavior
Changes:
- Updated fallback HTTPS server block to use ssl_reject_handshake
- Added condition to check for default certificate availability
- Changed status code from 500 to 503 for better HTTP semantics
- Documented SSL certificate handling behavior in README1 parent 806b081 commit 69bfdc1
2 files changed
Lines changed: 31 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
133 | 155 | | |
134 | 156 | | |
135 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
554 | 554 | | |
555 | 555 | | |
556 | 556 | | |
557 | | - | |
| 557 | + | |
558 | 558 | | |
559 | 559 | | |
560 | 560 | | |
| |||
563 | 563 | | |
564 | 564 | | |
565 | 565 | | |
566 | | - | |
567 | 566 | | |
| 567 | + | |
| 568 | + | |
568 | 569 | | |
569 | 570 | | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
570 | 577 | | |
571 | 578 | | |
572 | 579 | | |
| |||
0 commit comments