Commit 04c7aab
feat(Select): maintain size of select fields after value selection (#1899)
## 📝 Changes
A Select with size="md" or size="lg" shrinks by one size step once a
value is selected: md renders like sm, and lg renders like md, while sm
is unaffected.
Hardcoding variant="body2" on the selected value overrides the inherited
size, causing md and lg to render with the smaller body2 style.
Remove the hardcoded variant="body2" so the selected value inherits the
trigger's size
## ✅ Checklist
Easy UI has certain UX standards that must be met. In general,
non-trivial changes should meet the following criteria:
- [ ] Visuals match Design Specs in Figma
- [ ] Stories accompany any component changes
- [ ] Code is in accordance with our style guide
- [ ] Design tokens are utilized
- [ ] Unit tests accompany any component changes
- [ ] TSDoc is written for any API surface area
- [ ] Specs are up-to-date
- [ ] Console is free from warnings
- [ ] No accessibility violations are reported
- [ ] Cross-browser check is performed (Chrome, Safari, Firefox)
- [ ] Changeset is added
~Strikethrough~ any items that are not applicable to this pull request.
Co-authored-by: Justin Allen <justin@easypost.com>1 parent 044775e commit 04c7aab
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | | - | |
128 | | - | |
| 126 | + | |
129 | 127 | | |
130 | 128 | | |
131 | 129 | | |
| |||
0 commit comments