Commit 3385cbb
authored
# Description
The params were not nested at the root level for report creation which
is required so params like `columns` and `additional_columns` were not
accepted at the API. This PR corrects the nesting to put them at the
root which should fix these params when generating reports. (closes
#658)
Additionally, un-nested all cassette files. Years ago we tested this lib
against multiple frameworks at once which required multiple sets of
cassettes which is no longer the case. The cassettes nested in a `net`
folder is no longer helpful, moving them up a level.
Finally, cleaned up a similar problem with webhooks that lingered from
years earlier where to avoid collisions, we had to differentiate the
urls used in webhook generation based on net version in use. Removed
that as a part of this too.
<!-- Please provide a general summary of your PR changes and link any
related issues or other pull requests. -->
# Testing
Re-recorded all affected cassettes (otherwise cassettes just moved
location).
<!--
Please provide details on how you tested this code. See below.
- All pull requests must be tested (unit tests where possible with
accompanying cassettes, or provide a screenshot of end-to-end testing
when unit tests are not possible)
- New features must get a new unit test
- Bug fixes/refactors must re-record existing cassettes
-->
# Pull Request Type
Please select the option(s) that are relevant to this PR.
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Improvement (fixing a typo, updating readme, renaming a variable
name, etc)
1 parent 2036b73 commit 3385cbb
267 files changed
Lines changed: 1100 additions & 1697 deletions
File tree
- EasyPost.Integration
- cassettes
- synchronous_mvc_controller
- synchronous
- EasyPost.Tests
- ServicesTests
- WithParameters
- cassettes
- address_service_with_parameters
- address_service
- api_key_service
- base_service
- batch_service_with_parameters
- batch_service
- beta_rate_service_with_parameters
- beta_rate_service
- beta_referral_service_with_parameters
- beta_referral_service
- carrier_account_service_with_parameters
- carrier_account_service
- carrier_metadata_with_parameters
- carrier_type_service
- claim_service_with_parameters
- client
- customer_portal_service_with_parameters
- customs_info_service_with_parameters
- customs_info_service
- customs_item_service_with_parameters
- customs_item_service
- embeddable_service_with_parameters
- end_shipper_service_with_parameters
- end_shipper_service
- event_service_with_parameters
- event_service
- exceptions
- insurance_service_with_parameters
- insurance_service
- luma_service_with_parameters
- luma_service
- net
- event_service
- webhook_service_with_parameters
- webhook_service
- order_service_with_parameters
- order_service
- parameters
- parcel_service_with_parameters
- parcel_service
- pickup_service_with_parameters
- pickup_service
- rate_service
- referral_customer_service_with_parameters
- referral_customer_service
- refund_service_with_parameters
- refund_service
- report_service_with_parameters
- report_service
- scan_form_service_with_parameters
- scan_form_service
- shipment_service_with_parameters
- shipment_service
- smartrate_service_with_parameters
- tracker_service_with_parameters
- tracker_service
- tracker
- user_service_with_parameters
- user_service
- webhook_service_with_parameters
- webhook_service
- EasyPost
- Parameters/Report
- Properties
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | 77 | | |
93 | 78 | | |
94 | 79 | | |
| |||
123 | 108 | | |
124 | 109 | | |
125 | 110 | | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | 111 | | |
130 | 112 | | |
131 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
0 commit comments