wording pass, fix UI oversights

Author: Eauldane

Snowcloak.Core/Snowcloak.Core.csproj

@@ -9,7 +9,7 @@
   <ItemGroup>
     <PackageReference Include="ElezenTools.Core" Version="15.5.5" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.10" />
-    <PackageReference Include="Snowcloak.API" Version="3.99.23" />
+    <PackageReference Include="Snowcloak.API" Version="3.99.24" />
     <PackageReference Update="Meziantou.Analyzer" Version="3.0.124">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Snowcloak/Services/UiFactory.cs

@@ -76,13 +76,13 @@ public SyncshellAdminUI CreateSyncshellAdminUi(GroupFullInfoDto dto)
     {
         return new SyncshellAdminUI(_loggerFactory.CreateLogger<SyncshellAdminUI>(), _snowMediator,
             _apiController, _configService, _fontService, _pairManager, dto, _performanceCollectorService, _syncshellBudgetService,
-            _dalamudUtilService);
+            _dalamudUtilService, _fileDialogManager, _imageTransferService);
     }
 
     public SyncshellEventsWindow CreateSyncshellEventsUi(GroupFullInfoDto dto)
     {
         return new SyncshellEventsWindow(_loggerFactory.CreateLogger<SyncshellEventsWindow>(), _snowMediator,
-            _apiController, _pairManager, _dalamudUtilService, _textureService, _imageTransferService, dto,
+            _apiController, _pairManager, _dalamudUtilService, _textureService, _imageTransferService, _fileDialogManager, dto,
             _performanceCollectorService);
     }
 
@@ -126,7 +126,7 @@ public RoomAdministrationWindow CreateRoomAdministrationWindow(string roomId)
     {
         return new RoomAdministrationWindow(_loggerFactory.CreateLogger<RoomAdministrationWindow>(), _snowMediator,
             _apiController, _chatService, _pairManager, _chatIdentityResolver, _roleplayClientService,
-            _performanceCollectorService, roomId);
+            _fileDialogManager, _imageTransferService, _performanceCollectorService, roomId);
     }
 
     public PairRequestConfirmationWindow CreatePairRequestConfirmationWindow(string ident, string characterName, string pluginName)

Snowcloak/Snowcloak.csproj

@@ -40,7 +40,7 @@
     <PackageReference Include="NAudio" Version="2.3.0" />
     <PackageReference Include="Penumbra.Api" Version="5.15.1" />
     <PackageReference Include="Scrutor" Version="7.0.0" />
-    <PackageReference Include="Snowcloak.API" Version="3.99.23" />
+    <PackageReference Include="Snowcloak.API" Version="3.99.24" />
     <PackageReference Include="Snowcloak.CacheFile" Version="3.2.2.1" />
     <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.20.0" />
     <PackageReference Include="Vortice.DXGI" Version="3.8.3" />

Snowcloak/UI/CharaDataHubGposeTogetherTab.cs

@@ -210,19 +210,19 @@ private void DrawLobbyUser(GposeLobbyUserData user,
             {
                 PlayerInteractionService.SetMarkerAndOpenMap(new(user.WorldData.Value.PositionX, user.WorldData.Value.PositionY, user.WorldData.Value.PositionZ), user.Map);
             }
-            ElezenImgui.AttachTooltip(string.Format("{0}" + ElezenImgui.TooltipSeparator + "Note: Click to open the users location on your map." + Environment.NewLine + "Note: For GPose synchronization to work properly, you must be on the same map.",
+            ElezenImgui.AttachTooltip(string.Format("{0}" + ElezenImgui.TooltipSeparator + "Note: Click to open the users location on your map." + Environment.NewLine + "Note: For GPose synchronisation to work properly, you must be on the same map.",
                 sameMapAndServer.SameMap ? "You are on the same map." : "You are not on the same map."));
 
             ImGui.SameLine();
             ElezenImgui.ShowIcon(FontAwesomeIcon.Globe, sameMapAndServer.SameServer ? ImGuiColors.ParsedGreen : ImGuiColors.DalamudRed);
-            ElezenImgui.AttachTooltip(string.Format("{0}" + ElezenImgui.TooltipSeparator + "Note: GPose synchronization is not dependent on the current server, but you will have to spawn a character for the other lobby users.",
+            ElezenImgui.AttachTooltip(string.Format("{0}" + ElezenImgui.TooltipSeparator + "Note: GPose synchronisation is not dependent on the current server, but you will have to spawn a character for the other lobby users.",
                 sameMapAndServer.SameServer ? "You are on the same server." : "You are not on the same server."));
 
             ImGui.SameLine();
             ElezenImgui.ShowIcon(FontAwesomeIcon.Running, sameMapAndServer.SameEverything ? ImGuiColors.ParsedGreen : ImGuiColors.DalamudRed);
             ElezenImgui.AttachTooltip((sameMapAndServer.SameEverything ? "You are in the same instanced area." : "You are not in the same instanced area.") + ElezenImgui.TooltipSeparator +
                                           "Note: Users not in your instance, but on the same map, will be drawn as floating wisps." + Environment.NewLine
-                                              + "Note: GPose synchronization is not dependent on the current instance, but you will have to spawn a character for the other lobby users.");
+                                              + "Note: GPose synchronisation is not dependent on the current instance, but you will have to spawn a character for the other lobby users.");
 
             using (ImRaii.Disabled(!_dalamudUtilService.IsInGpose))
             {

Snowcloak/UI/Components/Account/AccountUidGenerationFlow.cs

@@ -68,7 +68,7 @@ private void ConsumeOperation()
             {
                 _success = true;
                 _message = string.Format(CultureInfo.InvariantCulture,
-                    "Created account UID {0}. Stored {1} account key(s), including {2} new key(s), and assigned this character. Attempting to connect.",
+                    "Created account UID {0}. Registered {1} account key(s), including {2} new key(s), and assigned this character. Attempting to connect.",
                     result.Uid, result.SecretKeyCount, result.NewSecretKeyCount);
                 _ = _apiController.CreateConnections();
             }

Snowcloak/UI/Components/AdvancedSettingsPanel.cs

@@ -63,6 +63,7 @@ public void Draw(CharacterData? lastCreatedCharacterData)
         {
             _mediator.Publish(new UiToggleMessage(typeof(EventViewerUI)));
         }
+        
 
         var holdCombatApplication = _configService.Current.HoldCombatApplication;
         if (ImGui.Checkbox("Hold application during combat", ref holdCombatApplication))
@@ -74,6 +75,7 @@ public void Draw(CharacterData? lastCreatedCharacterData)
 
             _configService.Update(c => c.HoldCombatApplication = holdCombatApplication);
         }
+        ElezenImgui.DrawHelpText("Prevents applying character data if Snowcloak detects you're in combat. May help avoid hitches.");
 
         ImGui.Separator();
         _fontService.BigText("Debug");
@@ -127,7 +129,7 @@ public void Draw(CharacterData? lastCreatedCharacterData)
         {
             _configService.Update(c => c.LogPerformance = logPerformance);
         }
-        ElezenImgui.DrawHelpText("Enabling this can incur a (slight) performance impact. Enabling this for extended periods of time is not recommended.");
+        ElezenImgui.DrawHelpText("Enabling this can incur a performance impact. Enabling this for extended periods of time is not recommended, and should only be used for debugging.");
 
         using (ImRaii.Disabled(!logPerformance))
         {

Snowcloak/UI/Components/AnalysisBrowser.cs

@@ -228,7 +228,7 @@ private void DrawStatusAndStats(IAnalysisSource source, bool needAnalysis, bool
                 ImGui.TextColored(ImGuiColors.DalamudOrange, FontAwesomeIcon.ExclamationTriangle.ToIconString());
             ImGui.SameLine(0f, 6f * scale);
             ImGui.TextColored(ImGuiColors.DalamudOrange,
-                string.Format(CultureInfo.InvariantCulture, "This exceeds the default auto-pause thresholds ({0} MiB VRAM / {1}k triangles) other clients use.",
+                string.Format(CultureInfo.InvariantCulture, "This exceeds the default auto-pause thresholds ({0} MiB VRAM / {1}k triangles) other clients use, and may be paused by them.",
                     PerformanceBudgetPolicy.LegacyAutoBlockVramThresholdMiB, PerformanceBudgetPolicy.LegacyAutoBlockTrianglesThresholdThousands));
             ImGuiHelpers.ScaledDummy(new Vector2(0, 4));
         }

Snowcloak/UI/Components/ChatConversationView.cs

@@ -328,7 +328,7 @@ private void DrawHeader(ConversationSnapshot conversation)
         }
 
         ImGui.SameLine();
-        if (ElezenImgui.ShowIconButton(FontAwesomeIcon.ExternalLinkAlt, "Open conversation in a separate window"))
+        if (ElezenImgui.ShowIconButton(FontAwesomeIcon.ExternalLinkAlt, "Open conversation in a pop-out window"))
         {
             _mediator.Publish(new OpenChatPopoutMessage(conversation.Key));
         }

Snowcloak/UI/Components/CompactPairNotePopup.cs

@@ -40,7 +40,7 @@ public void Draw(PairManager pairManager, bool openPopupOnAdd)
         }
         else
         {
-            ElezenImgui.WrappedText($"You have successfully added {_lastAddedUser.UserData.AliasOrUID}. Set a local note for the user in the field below:");
+            ElezenImgui.WrappedText($"You have successfully added {_lastAddedUser.UserData.AliasOrUID}. Set a note for them below:");
             ImGui.InputTextWithHint("##noteforuser", $"Note for {_lastAddedUser.UserData.AliasOrUID}", ref _lastAddedUserComment, 100);
             if (ElezenImgui.ShowIconButton(Dalamud.Interface.FontAwesomeIcon.Save, "Save Note"))
             {

Snowcloak/UI/Components/DrawGroupPair.cs

@@ -381,7 +381,7 @@ protected override float DrawRightSide(float textPosY, float originalY)
                         permissions
                     ));
                 }
-                ElezenImgui.AttachTooltip("Sets your allowance for sound synchronization for this Syncshell member." +
+                ElezenImgui.AttachTooltip("Whether or not sound synchronisation is allowed for this Syncshell member." +
                                               Environment.NewLine + "Disabling applies even without an individual pair.");
 
                 var isDisableAnims = permissions.IsDisableAnimations();
@@ -397,7 +397,7 @@ protected override float DrawRightSide(float textPosY, float originalY)
                         permissions
                     ));
                 }
-                ElezenImgui.AttachTooltip("Sets your allowance for animation synchronization for this Syncshell member." +
+                ElezenImgui.AttachTooltip("Whether or not animation sync is allowed for this Syncshell member." +
                                               Environment.NewLine +"Disabling applies even without an individual pair.");
 
                 var isDisableVfx = permissions.IsDisableVFX();
@@ -413,7 +413,7 @@ protected override float DrawRightSide(float textPosY, float originalY)
                         permissions
                     ));
                 }
-                ElezenImgui.AttachTooltip("Sets your allowance for VFX synchronization for this Syncshell member." +
+                ElezenImgui.AttachTooltip("Whether or not VFX sync is allowed for this Syncshell member." +
                                               Environment.NewLine + "Disabling applies even without an individual pair.");
 
                 ImGui.Separator();