fix/proxy remote url can change#238
Open
2e0byo wants to merge 4 commits into
Open
Conversation
2e0byo
force-pushed
the
fix/proxy-remote-url-can-change
branch
from
cc37401 to
c72f44b
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I wrote the proxy, I assumed tidal's upstream URL would stay fixed. Here on holiday in Milan, it's changed. I don't know if that's regional or not, but it makes sense to look it up.
I've assumed that all tracks will have the same proxy url within a session. This could still fail if:
In which case let's open an issue and fix it when it comes in.
The
Lazy[T]proxy class is my current favourite way to get a typesafe| None.