fix(keda): ScaledObject correctness — Value semantics, cluster-pinned query, optional CPU trigger#10893
Merged
manpreetkaur-arch merged 1 commit intoJun 8, 2026
Conversation
…query, CPU safety net Ratio queries never exceed 1.0, so AverageValue math capped demand at 2 pods regardless of load; metricType Value scales proportionally. Query pinned to the EKS cluster so co-labeled OKD series can't pollute the signal. Co-Authored-By: skettkepalli <sridhar.ettkepalli@eclipse-foundation.org>
netomi
reviewed
Jun 4, 2026
netomi
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two correctness fixes in the KEDA ScaledObject template (full analysis and measurements in #10892):
metricType: Value— the prometheus trigger used the defaultAverageValue, which for a ratio query (never above 1.0) caps replica demand atceil(1/threshold)pods regardless of load.keda.clusterName; without the pin, co-labeled series from other clusters pollute the average. Staging values seteks-staging(verified against the live series).Also parameterizes the smoothing window and adds an optional in-cluster CPU trigger, rendered only when
keda.cpuUtilizationis set. Staging tuning values are unchanged.Tested end-to-end on eks-staging — details in #10892.
Signed-off-by: skettkepalli sridhar.ettkepalli@eclipse-foundation.org