This repository was archived by the owner on Apr 4, 2023. It is now read-only.
fix(ios): FirebaseCrashlytics release mode and delegate handling improvements#1714
Merged
EddyVerbruggen merged 2 commits intoEddyVerbruggen:masterfrom Nov 2, 2020
Conversation
3 tasks
|
It looks like #1640 (comment) has been resolved here 👍 |
Owner
|
Ah, nice, I missed this PR and fixed that first issue in the same way :) |
lambourn
reviewed
Nov 2, 2020
Collaborator
lambourn
left a comment
lambourn
left a comment
There was a problem hiding this comment.
minor: the semicolon causes a warning when main.m gets processed
warning: extra tokens at end of #import directive [-Wextra-tokens]
#import <FirebaseCrashlytics/FirebaseCrashlytics.h>;
Owner
|
@lambourn lol, that's probably why Github says there's a merge conflict on that line :) |
EddyVerbruggen
added a commit
that referenced
this pull request
Nov 2, 2020
…ovements #1714 - resolve merge conflict (will revert)
EddyVerbruggen
added a commit
that referenced
this pull request
Nov 2, 2020
…ovements #1714 - remove the semicolon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firebasesymbol to avoid occasional early garbage collection by v8 engineThis is published under
rcright now with @nativescript/firebase11.1.1-rc.0if anyone experiences issues related to above can try and please confirm here if it solved it for you.