Fix camera permissions race condition

Author: Jon Tzeng

CHANGELOG.md

@@ -12,6 +12,7 @@
 - fixed: ramps: Various Infinite UI/UX issues
 - fixed: Search keyboard not dismissing when submitting search
 - fixed: Auto-correct not disabled for search input
+- fixed: Inaccurate camera permissions detection
 - fixed: In-app review for iOS 18+
 
 ## 4.41.1 (2025-12-29)

src/components/modals/ScanModal.tsx

@@ -17,7 +17,7 @@ import { sprintf } from 'sprintf-js'
 import { useLayout } from '../../hooks/useLayout'
 import { lstrings } from '../../locales/strings'
 import { config } from '../../theme/appConfig'
-import { useSelector } from '../../types/reactRedux'
+import { useDispatch, useSelector } from '../../types/reactRedux'
 import { triggerHaptic } from '../../util/haptic'
 import { logActivity } from '../../util/logger'
 import { ModalButtons } from '../buttons/ModalButtons'
@@ -62,6 +62,7 @@ export const ScanModal: React.FC<Props> = props => {
     scanModalTitle
   } = props
 
+  const dispatch = useDispatch()
   const theme = useTheme()
   const styles = getStyles(theme)
 
@@ -87,13 +88,13 @@ export const ScanModal: React.FC<Props> = props => {
   // Mount effects
   React.useEffect(() => {
     setScanEnabled(true)
-    checkAndRequestPermission('camera').catch((error: unknown) => {
+    dispatch(checkAndRequestPermission('camera')).catch((error: unknown) => {
       showError(error)
     })
     return () => {
       setScanEnabled(false)
     }
-  }, [])
+  }, [dispatch])
 
   const handleBarCodeRead = (codes: Code[]): void => {
     setScanEnabled(false)

src/components/services/PermissionsManager.tsx

@@ -87,17 +87,24 @@ export async function requestContactsPermission(
 }
 
 /**
- * Checks permission and attempts to request permissions (only if checked
- * permission was 'denied')
+ * Checks permission and requests when denied, then syncs Redux with the
+ * resulting status.
  */
-export async function checkAndRequestPermission(
-  data: Permission
-): Promise<PermissionStatus> {
-  const status: PermissionStatus = await check(permissionNames[data])
+export const checkAndRequestPermission =
+  (permission: Permission): ThunkAction<Promise<PermissionStatus>> =>
+  async dispatch => {
+    let status: PermissionStatus = await check(permissionNames[permission])
 
-  if (status === 'denied') return await request(permissionNames[data])
-  else return status
-}
+    if (status === 'denied') {
+      status = await request(permissionNames[permission])
+    }
+
+    dispatch({
+      type: 'PERMISSIONS/UPDATE',
+      data: { [permission]: status }
+    })
+    return status
+  }
 
 export const checkIfDenied = (status: PermissionStatus) =>
   status === 'blocked' || status === 'denied' || status === 'unavailable'
@@ -126,7 +133,7 @@ export async function requestPermissionOnSettings(
 
   // User first time check. If mandatory, it needs to be checked if denied or accepted
   if (status === 'denied') {
-    const result = await checkAndRequestPermission(data)
+    const result = await request(permissionNames[data])
     return mandatory && checkIfDenied(result)
   }