Skip to content

Commit ca4cb77

Browse files
committed
Build address-modal title from supported name services
Localize scan_address_modal_title and add scan_address_modal_title_1s Hand-translated alongside the en_US source-of-truth update from the prior commit. Goes against the usual Crowdin-only-edits-translations practice; that's intentional — Crowdin is being phased out, so editing locale JSON directly here is fine.
1 parent 75f3433 commit ca4cb77

16 files changed

Lines changed: 43 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Unreleased (develop)
44

5+
- added: Resolve and display ZcashNames (.zcash) in the Zcash send flow and transaction history.
56
- changed: Remove free FIO handle creation flows.
67
- changed: Migrate Thorchain Savers and Thorchain Yield endpoints off NineRealms to gateway.liquify.com.
78

src/components/tiles/AddressTile2.tsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,12 +363,25 @@ export const AddressTile2 = React.forwardRef(
363363
})
364364

365365
const handleChangeAddress = useHandler(async () => {
366+
const nameServices: string[] = []
367+
if (fioPlugin != null) nameServices.push('FIO')
368+
if (coreWallet.currencyInfo.pluginId === 'ethereum')
369+
nameServices.push('ENS')
370+
if (coreWallet.currencyInfo.pluginId === 'zcash') nameServices.push('ZNS')
371+
const title =
372+
nameServices.length > 0
373+
? sprintf(
374+
lstrings.scan_address_modal_title_1s,
375+
nameServices.join(', ')
376+
)
377+
: lstrings.scan_address_modal_title
378+
366379
Airship.show<string | undefined>(bridge => (
367380
<AddressModal
368381
bridge={bridge}
369382
walletId={coreWallet.id}
370383
currencyCode={currencyCode}
371-
title={lstrings.scan_address_modal_title}
384+
title={title}
372385
/>
373386
))
374387
.then(async result => {

src/locales/en_US.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,8 @@ const strings = {
13681368
personalize_wallet_title: 'Personalize Your Wallet',
13691369
get_started_button: 'Get Started',
13701370
not_now_button: 'Not Now',
1371-
scan_address_modal_title: 'Enter Recipient FIO, ENS, or Public Address',
1371+
scan_address_modal_title: 'Enter Recipient Public Address',
1372+
scan_address_modal_title_1s: 'Enter Recipient %1$s or Public Address',
13721373
enter_any_title: 'Enter any of the following:',
13731374
enter_any_body:
13741375
'1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet',

src/locales/strings/de.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personalize Your Wallet",
10871087
"get_started_button": "Get Started",
10881088
"not_now_button": "Not Now",
1089-
"scan_address_modal_title": "Empfänger FIO, ENS oder öffentliche Adresse eingeben",
1089+
"scan_address_modal_title": "Öffentliche Adresse des Empfängers eingeben",
1090+
"scan_address_modal_title_1s": "Empfänger %1$s oder öffentliche Adresse eingeben",
10901091
"enter_any_title": "Enter any of the following:",
10911092
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
10921093
"enter_any_input_hint": "Enter any of the above",

src/locales/strings/enUS.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personalize Your Wallet",
10871087
"get_started_button": "Get Started",
10881088
"not_now_button": "Not Now",
1089-
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
1089+
"scan_address_modal_title": "Enter Recipient Public Address",
1090+
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
10901091
"enter_any_title": "Enter any of the following:",
10911092
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
10921093
"enter_any_input_hint": "Enter any of the above",

src/locales/strings/es.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personalize Your Wallet",
10871087
"get_started_button": "Get Started",
10881088
"not_now_button": "Not Now",
1089-
"scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
1089+
"scan_address_modal_title": "Introduce la dirección pública del destinatario",
1090+
"scan_address_modal_title_1s": "Introduce el destinatario %1$s o dirección pública",
10901091
"enter_any_title": "Enter any of the following:",
10911092
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
10921093
"enter_any_input_hint": "Enter any of the above",

src/locales/strings/esMX.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personaliza tu billetera",
10871087
"get_started_button": "Comenzar",
10881088
"not_now_button": "Ahora no",
1089-
"scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
1089+
"scan_address_modal_title": "Introduce la dirección pública del destinatario",
1090+
"scan_address_modal_title_1s": "Introduce el destinatario %1$s o dirección pública",
10901091
"enter_any_title": "Ingresa cualquiera de los siguientes:",
10911092
"enter_any_body": "1. Dirección pública para enviar dinero\n2. Clave privada para barrer fondos\n3. URI de Wallet Connect para conectar con una dApp\n4. URI de Edge Login para iniciar sesión en otro dispositivo\n\nEdge detectará automáticamente el formato de la URI y te permitirá seleccionar una billetera adecuada",
10921093
"enter_any_input_hint": "Ingresa cualquiera de los anteriores",

src/locales/strings/fr.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personalize Your Wallet",
10871087
"get_started_button": "Get Started",
10881088
"not_now_button": "Not Now",
1089-
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
1089+
"scan_address_modal_title": "Enter Recipient Public Address",
1090+
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
10901091
"enter_any_title": "Enter any of the following:",
10911092
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
10921093
"enter_any_input_hint": "Enter any of the above",

src/locales/strings/it.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "Personalizza Il Tuo Portafoglio",
10871087
"get_started_button": "Inizia",
10881088
"not_now_button": "Non ora",
1089-
"scan_address_modal_title": "Inserisci indirizzo FIO, ENS o indirizzo pubblico del destinatario",
1089+
"scan_address_modal_title": "Inserisci l'indirizzo pubblico del destinatario",
1090+
"scan_address_modal_title_1s": "Inserisci %1$s o l'indirizzo pubblico del destinatario",
10901091
"enter_any_title": "Inserisci uno dei seguenti elementi:",
10911092
"enter_any_body": "1. Indirizzo pubblico a cui inviare denaro\n2. Chiave privata per importare i fondi \n3. URI di Wallet Connect per connetterti a una dApp\n4. Edge Login URI per accedere su un altro dispositivo\n\nEdge rileverà automaticamente il formato URI e ti consentirà di selezionare un portafoglio appropriato",
10921093
"enter_any_input_hint": "Inserisci uno qualsiasi dei precedenti",

src/locales/strings/ja.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,8 @@
10861086
"personalize_wallet_title": "ハンドル名を決めてください",
10871087
"get_started_button": "始める",
10881088
"not_now_button": "後で",
1089-
"scan_address_modal_title": "受信者のFIO、ENS、または公開アドレスを入力してください",
1089+
"scan_address_modal_title": "受信者の公開アドレスを入力してください",
1090+
"scan_address_modal_title_1s": "受信者の%1$sまたは公開アドレスを入力してください",
10901091
"enter_any_title": "次のいずれかを入力します:",
10911092
"enter_any_body": "1. 送金先の公開アドレス\n2. スイープ用の秘密鍵\n3. dAppに接続するためのWallet Connect URI\n4. 別のデバイスにログインするためのEdge Login URI\n\nEdgeはURIの形式を自動で検出するため、適切なウォレットを選択することができます。",
10921093
"enter_any_input_hint": "上記のいずれかを入力してください",

0 commit comments

Comments
 (0)