Fix login scene lint warnings

Author: swansontec

eslint.config.mjs

@@ -239,10 +239,6 @@ export default [
       'src/components/rows/TxCryptoAmountRow.tsx',
       'src/components/scenes/AssetSettingsScene.tsx',
       'src/components/scenes/ChangeMiningFeeScene.tsx',
-      'src/components/scenes/ChangePasswordScene.tsx',
-      'src/components/scenes/ChangePinScene.tsx',
-      'src/components/scenes/ChangeUsernameScene.tsx',
-      'src/components/scenes/CoinRankingDetailsScene.tsx',
 
       'src/components/scenes/ConfirmScene.tsx',
       'src/components/scenes/CreateWalletAccountSelectScene.tsx',
@@ -285,19 +281,17 @@ export default [
       'src/components/scenes/Loans/LoanDetailsScene.tsx',
       'src/components/scenes/Loans/LoanManageScene.tsx',
       'src/components/scenes/Loans/LoanStatusScene.tsx',
-      'src/components/scenes/LoginScene.tsx',
+
       'src/components/scenes/ManageTokensScene.tsx',
       'src/components/scenes/MigrateWalletCalculateFeeScene.tsx',
       'src/components/scenes/MigrateWalletCompletionScene.tsx',
 
       'src/components/scenes/NotificationCenterScene.tsx',
       'src/components/scenes/NotificationScene.tsx',
-      'src/components/scenes/OtpRepairScene.tsx',
+
       'src/components/scenes/OtpSettingsScene.tsx',
-      'src/components/scenes/PasswordRecoveryScene.tsx',
-      'src/components/scenes/PromotionSettingsScene.tsx',
 
-      'src/components/scenes/SecurityAlertsScene.tsx',
+      'src/components/scenes/PromotionSettingsScene.tsx',
 
       'src/components/scenes/SpendingLimitsScene.tsx',
       'src/components/scenes/Staking/EarnScene.tsx',
@@ -312,7 +306,6 @@ export default [
       'src/components/scenes/TransactionDetailsScene.tsx',
 
       'src/components/scenes/TransactionsExportScene.tsx',
-      'src/components/scenes/UpgradeUsernameScreen.tsx',
 
       'src/components/scenes/WalletRestoreScene.tsx',
       'src/components/scenes/WcConnectionsScene.tsx',

src/components/scenes/ChangePasswordScene.tsx

@@ -10,7 +10,7 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'changePassword'> {}
 
-export const ChangePasswordScene = (props: Props) => {
+export const ChangePasswordScene: React.FC<Props> = props => {
   const { navigation } = props
   const account = useSelector(state => state.core.account)
   const context = useSelector(state => state.core.context)

src/components/scenes/ChangePinScene.tsx

@@ -10,16 +10,16 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'changePin'> {}
 
-export const ChangePinScene = (props: Props) => {
+export const ChangePinScene: React.FC<Props> = props => {
   const { navigation } = props
   const account = useSelector(state => state.core.account)
   const context = useSelector(state => state.core.context)
   const dispatch = useDispatch()
 
-  const handleComplete = () => {
+  const handleComplete = useHandler(() => {
     logActivity(`PIN Changed: ${account.username}`)
     navigation.goBack()
-  }
+  })
 
   const handleLogEvent = useHandler((event, values) => {
     dispatch(logEvent(event, values))

src/components/scenes/ChangeUsernameScene.tsx

@@ -9,7 +9,7 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'changeUsername'> {}
 
-export const ChangeUsernameScene = (props: Props) => {
+export const ChangeUsernameScene: React.FC<Props> = props => {
   const { navigation, route } = props
   const { password } = route.params
   const dispatch = useDispatch()

src/components/scenes/LoginScene.tsx

@@ -34,15 +34,14 @@ export interface LoginParams {
   loginUiInitialRoute?: InitialRouteName
 }
 
-// Sneak the BlurView over to the login UI:
-// @ts-expect-error
+// @ts-expect-error Sneak the BlurView over to the login UI:
 global.ReactNativeBlurView = BlurView
 
 interface Props extends RootSceneProps<'login'> {}
 
 let firstRun = true
 
-export function LoginScene(props: Props) {
+export const LoginScene: React.FC<Props> = props => {
   const { navigation, route } = props
   const {
     experimentConfig,
@@ -82,7 +81,7 @@ export function LoginScene(props: Props) {
               initializeAccount(navigation as NavigationBase, account)
             )
           })
-          .catch(error => {
+          .catch((error: unknown) => {
             showError(error)
           })
       }
@@ -94,7 +93,7 @@ export function LoginScene(props: Props) {
               initializeAccount(navigation as NavigationBase, account)
             )
           })
-          .catch(error => {
+          .catch((error: unknown) => {
             showError(error)
           })
       }
@@ -115,7 +114,7 @@ export function LoginScene(props: Props) {
             initializeAccount(navigation as NavigationBase, account)
           )
         })
-        .catch(error => {
+        .catch((error: unknown) => {
           showError(error)
         })
     }
@@ -129,8 +128,8 @@ export function LoginScene(props: Props) {
     () => ({
       callback() {
         Keyboard.dismiss()
-        showHelpModal(navigation as NavigationBase).catch(err => {
-          showDevError(err)
+        showHelpModal(navigation as NavigationBase).catch((error: unknown) => {
+          showDevError(error)
         })
       },
       text: lstrings.string_help
@@ -153,8 +152,8 @@ export function LoginScene(props: Props) {
   })
 
   const handleSendLogs = useHandler(() => {
-    dispatch(showSendLogsModal()).catch(err => {
-      showError(err)
+    dispatch(showSendLogsModal()).catch((error: unknown) => {
+      showError(error)
     })
   })
 

src/components/scenes/OtpRepairScene.tsx

@@ -15,7 +15,7 @@ export interface OtpRepairParams {
 
 interface Props extends EdgeAppSceneProps<'otpRepair'> {}
 
-export const OtpRepairScene = (props: Props) => {
+export const OtpRepairScene: React.FC<Props> = props => {
   const { navigation, route } = props
   const { otpError } = route.params
   const account = useSelector(state => state.core.account)

src/components/scenes/PasswordRecoveryScene.tsx

@@ -10,7 +10,7 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'passwordRecovery'> {}
 
-export const ChangeRecoveryScene = (props: Props) => {
+export const ChangeRecoveryScene: React.FC<Props> = props => {
   const { navigation } = props
   const account = useSelector(state => state.core.account)
   const context = useSelector(state => state.core.context)

src/components/scenes/SecurityAlertsScene.tsx

@@ -9,7 +9,7 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'securityAlerts'> {}
 
-export const SecurityAlertsScene = (props: Props) => {
+export const SecurityAlertsScene: React.FC<Props> = props => {
   const { navigation } = props
   const account = useSelector(state => state.core.account)
   const context = useSelector(state => state.core.context)

src/components/scenes/UpgradeUsernameScreen.tsx

@@ -11,7 +11,7 @@ import { SceneWrapper } from '../common/SceneWrapper'
 
 interface Props extends EdgeAppSceneProps<'upgradeUsername'> {}
 
-export const UpgradeUsernameScene = (props: Props) => {
+export const UpgradeUsernameScene: React.FC<Props> = props => {
   const { navigation } = props
   const account = useSelector(state => state.core.account)
   const context = useSelector(state => state.core.context)