Fix/extend minimum errors

- Show the selected crypto in the error
- Add generic vendor error handling when no minimums are given

Author: Jon Tzeng

src/components/scenes/GiftCardPurchaseScene.tsx

@@ -366,22 +366,23 @@ export const GiftCardPurchaseScene: React.FC<Props> = props => {
 
     const caip19 = tokenInfo.caip19
 
+    // Get currency code for display (used in warnings, success, and error messages)
+    const currencyCode =
+      tokenId != null
+        ? account.currencyConfig[wallet.currencyInfo.pluginId]?.allTokens[
+            tokenId
+          ]?.currencyCode ?? wallet.currencyInfo.currencyCode
+        : wallet.currencyInfo.currencyCode
+
     // Check minimum amount for selected token
     if (selectedAmount < tokenInfo.minimumAmountInUSD) {
-      const currencyCode =
-        tokenId != null
-          ? account.currencyConfig[wallet.currencyInfo.pluginId]?.allTokens[
-              tokenId
-            ]?.currencyCode ?? wallet.currencyInfo.currencyCode
-          : wallet.currencyInfo.currencyCode
-
       setMinimumWarning({
         header: sprintf(
-          lstrings.gift_card_minimum_warning_header,
+          lstrings.gift_card_minimum_warning_header_1s,
           currencyCode
         ),
         footer: sprintf(
-          lstrings.gift_card_minimum_warning_footer,
+          lstrings.gift_card_minimum_warning_footer_1s,
           formatMinimumInBrandCurrency(tokenInfo.minimumAmountInUSD)
         )
       })
@@ -424,13 +425,6 @@ export const GiftCardPurchaseScene: React.FC<Props> = props => {
 
       // Convert quantity to native amount (crypto amount to pay)
       // The quantity is in the token's standard units (e.g., BTC, ETH)
-      const currencyCode =
-        tokenId != null
-          ? account.currencyConfig[wallet.currencyInfo.pluginId]?.allTokens[
-              tokenId
-            ]?.currencyCode ?? wallet.currencyInfo.currencyCode
-          : wallet.currencyInfo.currencyCode
-
       const multiplier =
         tokenId != null
           ? account.currencyConfig[wallet.currencyInfo.pluginId]?.allTokens[
@@ -568,23 +562,36 @@ export const GiftCardPurchaseScene: React.FC<Props> = props => {
         return
       }
 
-      // Check for minimum amount error from API
+      // Check for minimum amount error from API (with specific minimum)
       const minimumMatch = /Minimum cart cost should be above: ([\d.]+)/.exec(
         errorMessage
       )
 
+      // Check for generic "order too small" error (no specific minimum)
+      const isGenericMinimumError = errorMessage.includes(
+        'Order amount is too small'
+      )
+
       if (minimumMatch != null) {
         const minimumUSD = parseFloat(minimumMatch[1])
         setMinimumWarning({
           header: sprintf(
-            lstrings.gift_card_minimum_warning_header,
-            'this cryptocurrency'
+            lstrings.gift_card_minimum_warning_header_1s,
+            currencyCode
           ),
           footer: sprintf(
-            lstrings.gift_card_minimum_warning_footer,
+            lstrings.gift_card_minimum_warning_footer_1s,
             formatMinimumInBrandCurrency(minimumUSD)
           )
         })
+      } else if (isGenericMinimumError) {
+        setMinimumWarning({
+          header: sprintf(
+            lstrings.gift_card_minimum_warning_header_1s,
+            currencyCode
+          ),
+          footer: lstrings.gift_card_minimum_warning_generic
+        })
       } else {
         // Show ErrorCard for other errors
         setError(err)

src/locales/en_US.ts

@@ -1918,10 +1918,12 @@ const strings = {
   gift_card_network_error:
     'Unable to load gift cards. Please check your network connection.',
   gift_card_minimum_warning_title: 'Below Minimum',
-  gift_card_minimum_warning_header:
-    'The selected amount is below the minimum for %s.',
-  gift_card_minimum_warning_footer:
-    'Please select a different payment method or increase your purchase amount to at least %s.',
+  gift_card_minimum_warning_header_1s:
+    'The selected amount is below the minimum for %1$s.',
+  gift_card_minimum_warning_footer_1s:
+    'Please select a different payment method or increase your purchase amount to at least %1$s.',
+  gift_card_minimum_warning_generic:
+    'The selected amount is too small for this cryptocurrency. Please select a different payment method or increase your purchase amount.',
   gift_card_redeemed_cards: 'Redeemed Cards',
   gift_card_unmark_as_redeemed: 'Unmark as Redeemed',
   gift_card_active_cards: 'Active Cards',

src/locales/strings/enUS.json

@@ -1491,8 +1491,9 @@
   "gift_card_more_options": "Browse more gift cards",
   "gift_card_network_error": "Unable to load gift cards. Please check your network connection.",
   "gift_card_minimum_warning_title": "Below Minimum",
-  "gift_card_minimum_warning_header": "The selected amount is below the minimum for %s.",
-  "gift_card_minimum_warning_footer": "Please select a different payment method or increase your purchase amount to at least %s.",
+  "gift_card_minimum_warning_header_1s": "The selected amount is below the minimum for %1$s.",
+  "gift_card_minimum_warning_footer_1s": "Please select a different payment method or increase your purchase amount to at least %1$s.",
+  "gift_card_minimum_warning_generic": "The selected amount is too small for this cryptocurrency. Please select a different payment method or increase your purchase amount.",
   "gift_card_redeemed_cards": "Redeemed Cards",
   "gift_card_unmark_as_redeemed": "Unmark as Redeemed",
   "gift_card_active_cards": "Active Cards",