Hide Get Raw Keys behind Developer Mode#6069
Merged
Merged
Conversation
Contributor
Author
peachbits
approved these changes
Jul 10, 2026
Only show the wallet menu's Get Raw Keys option when Developer Mode is enabled. Wallets that fail to load still expose raw keys through the existing fallback so a broken wallet can always be recovered.
j0ntz
force-pushed
the
jon/hide-raw-keys-dev-mode
branch
from
July 10, 2026 23:57
28be422 to
c35e3d6
Compare
j0ntz
enabled auto-merge
July 10, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
- changed: Hide the wallet "Get Raw Keys" option behind Developer Mode, while still showing it for wallets that fail to load.Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Asana: https://app.asana.com/1/9976422036640/project/1201386023359449/task/1208354993842606
Hides the
Get Raw Keysitem in the wallet overflow menu unless the account has Developer Mode enabled. Raw Keys is a power-user tool; gating it behind Developer Mode declutters the menu for normal users while keeping the capability available to those who need it.The safety fallback is preserved: when a wallet fails to load (
wallet == null), Raw Keys still appears unconditionally, so keys can always be recovered from a broken wallet. This is handled by a separate early-return branch that is intentionally not gated.No change was needed to make the Raw Keys JSON read-only:
RawTextModalalready renders the content as read-only text (aParagraph, not an input) andgetRawKeyspassesdisableCopy.Implementation: read
state.ui.settings.developerModeOninWalletListMenuModal, and skip thegetRawKeysoption in the menu loop when Developer Mode is off.Test evidence (iOS sim, edge-funds) attached below: menu with Developer Mode ON shows Get Raw Keys; menu with Developer Mode OFF hides it.
Note
Low Risk
Small UI gating change in the wallet menu with an explicit recovery exception for wallets that fail to load; no changes to key export APIs or authentication.
Overview
Get Raw Keys in the wallet list overflow menu is now shown only when Developer Mode is enabled (
state.ui.settings.developerModeOn), so normal users see a simpler menu while power users can still reach raw key export from settings.The modal reads that flag and skips the
getRawKeysentry when building options for loaded wallets. Recovery is unchanged: if the wallet object is missing (wallet == null), the menu still offers Get Raw Keys (and archive) with no Developer Mode check, so keys can be exported from a broken wallet. Existing rules for light accounts (no seed/raw keys when username is null) and the loaded-wallet path are otherwise the same.CHANGELOG documents the behavior change.
Reviewed by Cursor Bugbot for commit c35e3d6. Bugbot is set up for automated code reviews on this repo. Configure here.