Skip to content

Add NYM swap partner icon mapping#6078

Merged
j0ntz merged 1 commit into
developfrom
jon/nym-swap-icon-mapping
Jul 16, 2026
Merged

Add NYM swap partner icon mapping#6078
j0ntz merged 1 commit into
developfrom
jon/nym-swap-icon-mapping

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

NYM swap partner (nymswap) transactions rendered the generic "Swap Funds" icon in transaction history and details because pluginIdIcons in src/actions/CategoriesActions.ts had no entry for the nymswap plugin id. This adds that mapping so the partner icon renders.

Path note: the icon asset is served at https://content.edge.app/exchangeIcons/nymswap/icon.png (verified 200 image/png), not the flat /nymswap.png path (403), so the entry uses the exchangeIcons/<pluginId>/icon.png convention (the same path src/util/CdnUris.ts builds for exchange icons). This is the same class of bug as the n.exchange task; the flat-path form used in EdgeApp/edge-react-gui#6075 resolves to a 403, which is why that icon is still missing.

Testing: forced pluginIdIcons.nymswap on the transaction rows via a throwaway local harness (reverted before commit) and confirmed the NYM partner icon loads from the content server and renders in the Ethereum Network transaction list on the iOS simulator (edge-funds). tsc --noEmit, jest, and eslint pass. Proof screenshot attached below.

Asana task: https://app.asana.com/0/1215088146871429/1216604842190279


Note

Low Risk
Single CDN URL mapping for display icons; no swap, auth, or transaction logic changes.

Overview
NYM swap (nymswap) transactions now show the partner icon in transaction history and details instead of the generic swap placeholder.

Adds a nymswap entry to pluginIdIcons in CategoriesActions.ts, using the content-server path exchangeIcons/nymswap/icon.png (the flat /nymswap.png URL returns 403). CHANGELOG updated for 4.50.0.

Reviewed by Cursor Bugbot for commit ffcec62. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence — nymswap tx icon

agent proof 1216604842190279 01 nymswap tx icon

agent proof 1216604842190279 01 nymswap tx icon

Captured by the agent's in-app test run (build-and-test).

@j0ntz

j0ntz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Approved per our self-review policy of minor GUI changes.

Asana task was not originally marked as staging (now is), so changelog also needs to be updated before landing

Map the nymswap plugin id to its content-server icon so NYM swap
transactions render the partner icon in transaction history and details
instead of the generic swap icon.
@j0ntz
j0ntz force-pushed the jon/nym-swap-icon-mapping branch from 09be11c to ffcec62 Compare July 16, 2026 19:49
@j0ntz
j0ntz enabled auto-merge July 16, 2026 20:05
@j0ntz
j0ntz merged commit 3b9b95d into develop Jul 16, 2026
7 checks passed
@j0ntz
j0ntz deleted the jon/nym-swap-icon-mapping branch July 16, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant