Add NYM swap partner icon mapping#6078
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
Contributor
Author
|
Approved per our self-review policy of minor GUI changes. Asana task was not originally marked as staging (now is), so changelog also needs to be updated before landing |
Map the nymswap plugin id to its content-server icon so NYM swap transactions render the partner icon in transaction history and details instead of the generic swap icon.
j0ntz
force-pushed
the
jon/nym-swap-icon-mapping
branch
from
July 16, 2026 19:49
09be11c to
ffcec62
Compare
j0ntz
enabled auto-merge
July 16, 2026 20:05
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
NYM swap partner (
nymswap) transactions rendered the generic "Swap Funds" icon in transaction history and details becausepluginIdIconsinsrc/actions/CategoriesActions.tshad no entry for thenymswapplugin id. This adds that mapping so the partner icon renders.Path note: the icon asset is served at
https://content.edge.app/exchangeIcons/nymswap/icon.png(verified200 image/png), not the flat/nymswap.pngpath (403), so the entry uses theexchangeIcons/<pluginId>/icon.pngconvention (the same pathsrc/util/CdnUris.tsbuilds for exchange icons). This is the same class of bug as the n.exchange task; the flat-path form used in EdgeApp/edge-react-gui#6075 resolves to a 403, which is why that icon is still missing.Testing: forced
pluginIdIcons.nymswapon the transaction rows via a throwaway local harness (reverted before commit) and confirmed the NYM partner icon loads from the content server and renders in the Ethereum Network transaction list on the iOS simulator (edge-funds).tsc --noEmit, jest, and eslint pass. Proof screenshot attached below.Asana task: https://app.asana.com/0/1215088146871429/1216604842190279
Note
Low Risk
Single CDN URL mapping for display icons; no swap, auth, or transaction logic changes.
Overview
NYM swap (
nymswap) transactions now show the partner icon in transaction history and details instead of the generic swap placeholder.Adds a
nymswapentry topluginIdIconsinCategoriesActions.ts, using the content-server pathexchangeIcons/nymswap/icon.png(the flat/nymswap.pngURL returns 403). CHANGELOG updated for 4.50.0.Reviewed by Cursor Bugbot for commit ffcec62. Bugbot is set up for automated code reviews on this repo. Configure here.