fixup! Update sideshift plugin with new optional API fields

Author: j0ntz

src/partners/sideshift.ts

@@ -159,7 +159,9 @@ const asSideshiftTx = asObject({
   depositNetwork: asOptional(asString),
   depositHash: asOptional(asString),
   depositContractAddress: asOptional(asString),
-  depositEvmChainId: asOptional(asNumber),
+  // asMaybe so an unexpected encoding (e.g. a numeric string) degrades to
+  // undefined instead of throwing and aborting the whole 5-day query block
+  depositEvmChainId: asMaybe(asNumber),
   invoiceAmount: asString,
   settleAddress: asObject({
     address: asString
@@ -169,7 +171,7 @@ const asSideshiftTx = asObject({
   settleNetwork: asOptional(asString),
   settleHash: asOptional(asString),
   settleContractAddress: asOptional(asString),
-  settleEvmChainId: asOptional(asNumber),
+  settleEvmChainId: asMaybe(asNumber),
   createdAt: asString,
   settledAt: asOptional(asString)
 })
@@ -371,6 +373,11 @@ export async function processSideshiftTx(
     status: statusMap[tx.status],
     orderId: tx.id,
     countryCode: null,
+    // On EVM networks, TRON, Aptos, Sui, NEAR, and Algorand, SideShift's
+    // depositHash is the internal sweep transaction (deposit contract to
+    // their wallet), not the customer's own deposit transaction. The API
+    // exposes no better field, so treat this as an order reference, not a
+    // pointer to the customer's on-chain payment.
     depositTxid: tx.depositHash,
     depositAddress,
     depositCurrency: tx.depositAsset,