fixup! Fix partner plugin logging, token normalization, and cache handling

Author: paullinator

src/partners/banxa.ts

@@ -93,6 +93,8 @@ interface CachedAssetInfo {
   pluginId: string | undefined
 }
 let banxaCoinsCache: Map<string, CachedAssetInfo> | null = null
+let banxaCoinsCacheTimestamp = 0
+const CACHE_TTL_MS = 24 * 60 * 60 * 1000 // 24 hours
 
 // Static fallback for historical coins no longer in the v2 API
 const BANXA_HISTORICAL_COINS: Record<string, CachedAssetInfo> = {
@@ -122,7 +124,10 @@ async function fetchBanxaCoins(
   apiKeyV2: string,
   log: ScopedLog
 ): Promise<Map<string, CachedAssetInfo>> {
-  if (banxaCoinsCache != null) {
+  if (
+    banxaCoinsCache != null &&
+    Date.now() - banxaCoinsCacheTimestamp < CACHE_TTL_MS
+  ) {
     return banxaCoinsCache
   }
 
@@ -196,6 +201,7 @@ async function fetchBanxaCoins(
   }
 
   banxaCoinsCache = cache
+  banxaCoinsCacheTimestamp = Date.now()
   log(`Loaded ${cache.size} coin/blockchain combinations from API`)
   return cache
 }

src/partners/changenow.ts

@@ -124,6 +124,8 @@ const currencyCache: CurrencyCache = {
   currencies: new Map(),
   loaded: false
 }
+let currencyCacheTimestamp = 0
+const CACHE_TTL_MS = 24 * 60 * 60 * 1000 // 24 hours
 
 /**
  * Fetch all currencies from ChangeNow API and populate the cache
@@ -132,7 +134,10 @@ async function loadCurrencyCache(
   log: ScopedLog,
   apiKey?: string
 ): Promise<void> {
-  if (currencyCache.loaded) {
+  if (
+    currencyCache.loaded &&
+    Date.now() - currencyCacheTimestamp < CACHE_TTL_MS
+  ) {
     return
   }
 
@@ -166,6 +171,7 @@ async function loadCurrencyCache(
     }
 
     currencyCache.loaded = true
+    currencyCacheTimestamp = Date.now()
     log(`Currency cache loaded with ${currencies.length} entries`)
   } catch (e) {
     log.error(`Error loading currency cache: ${e}`)

src/partners/godex.ts

@@ -114,11 +114,16 @@ interface GodexAssetInfo {
 }
 
 let godexCoinsCache: Map<string, GodexAssetInfo> | null = null
+let godexCoinsCacheTimestamp = 0
+const CACHE_TTL_MS = 24 * 60 * 60 * 1000 // 24 hours
 
 async function getGodexCoinsCache(
   log: ScopedLog
 ): Promise<Map<string, GodexAssetInfo>> {
-  if (godexCoinsCache != null) {
+  if (
+    godexCoinsCache != null &&
+    Date.now() - godexCoinsCacheTimestamp < CACHE_TTL_MS
+  ) {
     return godexCoinsCache
   }
 
@@ -154,6 +159,7 @@ async function getGodexCoinsCache(
     }
     log(`Coins cache loaded: ${cache.size} entries`)
     godexCoinsCache = cache
+    godexCoinsCacheTimestamp = Date.now()
     return cache
   } catch (e) {
     log.error(`Error loading coins cache: ${String(e)}`)

src/partners/letsexchange.ts

@@ -236,9 +236,15 @@ interface CoinInfo {
 
 let coinCache: Map<string, CoinInfo> | null = null
 let coinCacheApiKey: string | null = null
+let coinCacheTimestamp = 0
+const CACHE_TTL_MS = 24 * 60 * 60 * 1000 // 24 hours
 
 async function fetchCoinCache(apiKey: string, log: ScopedLog): Promise<void> {
-  if (coinCache != null && coinCacheApiKey === apiKey) {
+  if (
+    coinCache != null &&
+    coinCacheApiKey === apiKey &&
+    Date.now() - coinCacheTimestamp < CACHE_TTL_MS
+  ) {
     return // Already cached
   }
 
@@ -278,6 +284,7 @@ async function fetchCoinCache(apiKey: string, log: ScopedLog): Promise<void> {
   }
 
   coinCacheApiKey = apiKey
+  coinCacheTimestamp = Date.now()
   log(`Cached ${coinCache.size} coins`)
 }
 

src/partners/sideshift.ts

@@ -99,9 +99,14 @@ const asSideshiftCoinsResponse = asArray(asSideshiftCoin)
 // Cache for Sideshift coins data
 // Key: `${coin}-${network}` -> contract address or null for mainnet coins
 let sideshiftCoinsCache: Map<string, string | null> | null = null
+let sideshiftCoinsCacheTimestamp = 0
+const CACHE_TTL_MS = 24 * 60 * 60 * 1000 // 24 hours
 
 async function fetchSideshiftCoins(): Promise<Map<string, string | null>> {
-  if (sideshiftCoinsCache != null) {
+  if (
+    sideshiftCoinsCache != null &&
+    Date.now() - sideshiftCoinsCacheTimestamp < CACHE_TTL_MS
+  ) {
     return sideshiftCoinsCache
   }
 
@@ -124,6 +129,7 @@ async function fetchSideshiftCoins(): Promise<Map<string, string | null>> {
   }
 
   sideshiftCoinsCache = cache
+  sideshiftCoinsCacheTimestamp = Date.now()
   return cache
 }