-
Notifications
You must be signed in to change notification settings - Fork 18
Partner fixes: Banxa Klarna, getTxInfo disable, and deploy partner updates #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paullinator
wants to merge
10
commits into
master
Choose a base branch
from
paul/partnerFixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ce1b8d4
Feat: nexchange plugin
MMrj9 5e16f6f
Throw instead of pricing tokens as native gas tokens
paullinator 96229b1
Add Xgram
paullinator 084ddb0
Infer LetsExchange native network when API omits network fields
paullinator 4d0bc8d
Add missing partner asset and payment mappings
paullinator 70d713a
Load full ChangeNow currency list to resolve delisted assets
paullinator 19d1556
Add Banxa historical fallback for delisted ZEC
paullinator 78900c7
Disable getTxInfo endpoint
paullinator ed329b2
Add Banxa Klarna Checkout payment type mapping
paullinator a6407a1
Add Monad chain id 143 to EVM_CHAIN_IDS
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ambiguous native network inference
Medium Severity
LETSEXCHANGE_CURRENCY_TO_DEFAULT_NETWORKclaims only unambiguous 1:1 native tickers, but includes multi-chain symbols such asETH,MATIC,FTM, andAVAX. When LetsExchange omits network on a post-cutoff tx, those codes are forced onto a single chain, so L2/native or ERC-20 variants can get the wrongchainPluginIdand be priced incorrectly.Additional Locations (1)
src/partners/letsexchange.ts#L254-L264Reviewed by Cursor Bugbot for commit cad25fb. Configure here.