Update to be compatible with numpy 2.1#85
Merged
veghp merged 2 commits intoEdinburgh-Genome-Foundry:devfrom Aug 29, 2024
Merged
Update to be compatible with numpy 2.1#85veghp merged 2 commits intoEdinburgh-Genome-Foundry:devfrom
veghp merged 2 commits intoEdinburgh-Genome-Foundry:devfrom
Conversation
Member
|
Thank you! I'll have to make a few more tests and address some other issues, then I can make a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With numpy >= 2.1, there is an error triggered in
EnforceGCContent, indicating that calling "nonzero on 0d arrays" is not permitted.This PR updates the code to be compatible with numpy >= 2.1 (and still works for older versions).
Related to this issue:
#83
Similar in spirit to #84 (didn't see that PR when I originally issued this one.)