Skip to content

Webcomponents can be configured within the prefs.xml#166

Open
Diginaut wants to merge 1 commit into
developfrom
bug/165-prefs-namespace
Open

Webcomponents can be configured within the prefs.xml#166
Diginaut wants to merge 1 commit into
developfrom
bug/165-prefs-namespace

Conversation

@Diginaut
Copy link
Copy Markdown
Member

@Diginaut Diginaut commented Apr 23, 2026

Description, Context and related Issue

This change adds the ability to configure web-components directly within the prefs.xml file. Web-components can now be defined with key-value option pairs, allowing for flexible and centralized configuration management.

Changes Made:

  1. edirom-prefs.xml: Added a commented example demonstrating how web-components can be configured (e.g., edirom_keycloak_handler with URL, realm, client ID, and script path)
  2. getPreferences.xql: Enhanced the preferences retrieval logic to parse and return web-component configurations along with their options as a structured map

This enables applications to:

  • Dynamically load and configure web-components through the preferences system
  • Support multiple web-components with their individual settings

Closes #165

How Has This Been Tested?

  • With and without custom prefs.xml
  • With and without web-components entry in prefs.xml

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Improvement

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes at testing
  • All new and existing tests passed.

@Diginaut Diginaut added this to the 1.4.0 milestone Apr 23, 2026
@Diginaut Diginaut requested a review from daniel-jettka April 23, 2026 08:27
@Diginaut Diginaut self-assigned this Apr 23, 2026
@Diginaut Diginaut added Area: Usability Issue concerning usability Area: Web Component labels Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in Edirom Development Apr 23, 2026
@daniel-jettka
Copy link
Copy Markdown
Contributor

Hi @Diginaut Sorry I won't find time to review this. Can you please assign someone else?

@daniel-jettka daniel-jettka removed their request for review April 28, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Usability Issue concerning usability Area: Web Component

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[BUG] Namespace for prefs.xml prevents custom configs

2 participants